VRMS icon indicating copy to clipboard operation
VRMS copied to clipboard

update question and date picker

Open angela-lee1 opened this issue 1 year ago • 2 comments

Fixes #1729

What changes did you make and why did you make them ?

  • We need to update the question text and date picker on the 'Check In As a New User' and 'Create a New Profile' screens to accurately track when members first joined Hack for LA, as the current options are insufficient.
    • Changed the text to "IS THIS YOUR FIRST TIME ATTENDING A HACK FOR LA MEETING?"
    • Changed text to: "WHEN DID YOU FIRST JOIN HACK FOR LA?" in database
    • UPDATE the "year" component of the date picker so that the date displays years ranging from 2013 up to the current year
    • Changes are applied to both routes.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

[image](Screenshot 2024-10-21 at 2 06 24 PM)

Visuals after changes are applied

[image]( ! Screenshot 2024-10-27 at 7 09 44 PM) )

)

angela-lee1 avatar Oct 23 '24 14:10 angela-lee1

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b angela-lee1-update-question-datepicker-checkin-newuser-create-newprofile development
git pull https://github.com/angela-lee1/VRMS.git update-question-datepicker-checkin-newuser-create-newprofile

github-actions[bot] avatar Oct 23 '24 14:10 github-actions[bot]

@angela-lee1 As discussed during call, use a single date picker (Month & Year).

JackHaeg avatar Oct 29 '24 02:10 JackHaeg

@JackHaeg @trillium Here is the image for using a single date picker. [image](Screenshot 2024-11-04 at 4 30 39 PM)

angela-lee1 avatar Nov 04 '24 22:11 angela-lee1

This is looking great, @angela-lee1! Thanks for your work on this :)

To any reviewers looking at this PR - please hold off on reviewing / merging this PR until Angela comments that the mobile view is working as expected.

JackHaeg avatar Nov 04 '24 23:11 JackHaeg

  • [mobile]

  • [desktop]

@trillium yarn dev see if you can get the same UI. The month is in 3 capitalized letters in DB. Sorry about the package manager. Thank you.

angela-lee1 avatar Nov 06 '24 15:11 angela-lee1