VRMS icon indicating copy to clipboard operation
VRMS copied to clipboard
verified publisher icon hackforla

adapt ValidatedTextField to accept custom validation functions

Open angela-lee1 opened this issue 1 year ago • 13 comments

Fixes #1484

What changes did you make and why did you make them ?

  • Adapt ValidatedTextField to apply custom validations into the validate portion of the register function from react-hook-form

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

[image]( Screenshot 2024-10-14 at 1 35 26 PM )

angela-lee1 avatar Oct 14 '24 18:10 angela-lee1

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b angela-lee1-accept-custom-validation-functions development
git pull https://github.com/angela-lee1/VRMS.git accept-custom-validation-functions

github-actions[bot] avatar Oct 14 '24 18:10 github-actions[bot]

@angela-lee1 Just checking in on this PR! Were you able to address the styling concerns that @pluto-bell mentioned in her review above?

JackHaeg avatar Jan 31 '25 00:01 JackHaeg

@JackHaeg will get this resolved before next team meeting. Sorry.

angela-lee1 avatar Jan 31 '25 00:01 angela-lee1

No problem, @angela-lee1! Thanks in advance for working on this!

JackHaeg avatar Feb 04 '25 01:02 JackHaeg

Hi @angela-lee1 Just checking in on this PR :)

When you have a moment, can you please provide an update with the following information:

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures or links* (if necessary): "Add any pictures or links that will help illustrate what you are working on."
  • remember to add links to the top of the issue if they are going to be needed again.

JackHaeg avatar Feb 11 '25 02:02 JackHaeg

@JackHaeg I am terribly sorry. I don't have any blockers. I will get it done by this Friday at the end of the day.

I made and pushed up the changes. I might need Trillium's help with the merge conflict. Screenshot 2025-02-16 at 10 42 12 AM

angela-lee1 avatar Feb 12 '25 02:02 angela-lee1

Hi @angela-lee1 No worries at all - seriously!! Thanks so much for confirming and for making these updates to the PR :)

JackHaeg avatar Feb 12 '25 03:02 JackHaeg

@angela-lee1 Just checking in since I saw an the additional commit submitted last week. Is this PR ready for review?

Based on your last comment, it sounds like you might just need Trilliums assistance with the merge conflicts, correct?

JackHaeg avatar Feb 25 '25 02:02 JackHaeg

Per @angela-lee1 this PR is ready for review.

JackHaeg avatar Feb 25 '25 03:02 JackHaeg

@angela-lee1 To resolve merge conflicts

JackHaeg avatar Aug 19 '25 02:08 JackHaeg

Hi @angela-lee1 - Just checking in! Can you please provide an update on when you believe these merge conflicts will be addressed?

JackHaeg avatar Sep 11 '25 20:09 JackHaeg

@JackHaeg, I got sick last weekend, sorry about procrastinating. I was planning to use last weekend for this. Yes, I will work on it tonight or tomorrow night. The ETA is September 13th.

angela-lee1 avatar Sep 11 '25 22:09 angela-lee1

Hi @angela-lee1 just checking in on this PR :) Whenever you have a moment, can you please resolve these merge conflicts so that we can merge this PR?

JackHaeg avatar Sep 23 '25 01:09 JackHaeg