VRMS icon indicating copy to clipboard operation
VRMS copied to clipboard
verified publisher icon hackforla

Updated HTML to MUI components on index.jsx

Open nora-zajzon opened this issue 1 year ago • 1 comments

Fixes #1679

What changes did you make and why did you make them?

  • Changed all the HTML components to MUI applicable components
  • Used inline styling

Screenshots of Proposed Changes to the Website (if any)

Visuals before changes were applied Screenshot 2024-09-24 at 8 27 20 PM
Visuals after changes were applied Screenshot 2024-09-25 at 3 19 53 PM

nora-zajzon avatar Sep 25 '24 03:09 nora-zajzon

I pulled down the changes to my local environment and verified that all HTML components have been updated to MUI. The visuals match the screenshot. Great work! Thank you for contributing to HackForLA.

angela-lee1 avatar Oct 08 '24 14:10 angela-lee1

Hi @bconti123 - thanks for reviewing this PR!

Normally, yes, the next step would be to "merge pull request", however after discussing this PR further with @trillium, we will be closing this issue as unplanned because:

  1. This component is not currently used by stakeholders in our app, and
  2. The changes implemented by this PR impact the usability of the table shown due to higher levels of padding, which negatively impacts the readability of this table (especially given the higher number of projects on PROD).

Given that, I will close this PR as unplanned.

JackHaeg avatar Mar 06 '25 21:03 JackHaeg