VRMS icon indicating copy to clipboard operation
VRMS copied to clipboard
verified publisher icon hackforla

Update newuser to mui

Open angela-lee1 opened this issue 1 year ago • 6 comments

Fixes #1720

What changes did you make and why did you make them ?

  • Replace standard HTML components with applicable MUI components.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

[image]( Screenshot 2024-09-14 at 5 56 12 PM )

Visuals after changes are applied

[image]( Screenshot 2024-09-14 at 6 30 52 PM )

angela-lee1 avatar Sep 14 '24 23:09 angela-lee1

@awlFCCamp did you delete the bot instructions for checking out this branch?

bkmorgan3 avatar Sep 16 '24 18:09 bkmorgan3

@bkmorgan3 I don't think I did. Are you referring to one of the GitHub Actions being deleted? I only modified and pushed one file(NewUser.jsx). didn't do anything to .github.

angela-lee1 avatar Sep 16 '24 18:09 angela-lee1

@bkmorgan3 You were concerned my "Add Pull Request Instructions ..." didn't get run. In one of the yml files we need to change uses: actions/upload-artifact@v2 to uses: actions/upload-artifact@v3 Hope I am correct here. @trillium can you chime in? Thank you!

angela-lee1 avatar Sep 16 '24 18:09 angela-lee1

@bkmorgan3 You were concerned my "Add Pull Request Instructions ..." didn't get run. In one of the yml files we need to change uses: actions/upload-artifact@v2 to uses: actions/upload-artifact@v3 Hope I am correct here. @trillium can you chime in? Thank you!

Yeah, hopefully the github action change will resolve this

trillium avatar Sep 24 '24 01:09 trillium

@trillium No, no. Its just new UI I am not used to seeing. I just needed to click View Command Line Instructions under the tests module. All good

bkmorgan3 avatar Sep 24 '24 01:09 bkmorgan3

Ah, gottcha. Regardless, we've currently got some errors in our github toolchain

trillium avatar Sep 24 '24 01:09 trillium