VRMS icon indicating copy to clipboard operation
VRMS copied to clipboard

Migrated edit users to Material UI

Open ntrehan opened this issue 1 year ago • 1 comments

Fixes #1723

What changes did you make and why did you make them ?

  • Migrated editUsers.js to Material UI

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

ntrehan avatar Aug 14 '24 00:08 ntrehan

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ntrehan-1723 development
git pull https://github.com/ntrehan/VRMS.git 1723

github-actions[bot] avatar Aug 14 '24 00:08 github-actions[bot]

@trillium I see that you approved these changes on this PR. Can we go ahead and merge?

JackHaeg avatar Feb 14 '25 01:02 JackHaeg

@trillium & @ntrehan:

  • This PR was completed prior to the introduction of the VRMS Admin feature (that allows admins to promote/demote other admins).
  • The VRMS Admin feature is currently implemented in Dev (see attached screenshot below)

Question:

  • Will this PR result in the "VRMS Admin" component using MUI styling, or will it default to the previous styling?
  • If it will result in the old styling or merging will be difficult with these new changes, should we either update this PR with this fix, or create a new issue to track this change entirely?
Screenshot of current Dev build with "VRMS Admin" feature

Edit Users Page with VRMS Admin feature

JackHaeg avatar Mar 11 '25 03:03 JackHaeg

@trillium Please see my comment above and let me know your thoughts - https://github.com/hackforla/VRMS/pull/1727#issuecomment-2712448409

JackHaeg avatar May 15 '25 22:05 JackHaeg