VRMS icon indicating copy to clipboard operation
VRMS copied to clipboard

Migrated newUserForm.js to MUI

Open ntrehan opened this issue 1 year ago • 1 comments

Fixes #1693

What changes did you make and why did you make them ?

  • Changed the contents of NewUserForm.js from regular HTML to Material UI as part of migration

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals of empty form before changes are applied

image

Visuals of empty after changes are applied

image

Visuals of filled form before changes are applied

image

Visuals of filled form before changes are applied

image

Visuals of filled form after changes are applied

image

Test 1 : create a new user that has never attended Hack Night before. Result - Passed

image

Test 2 : create a new user that has attended Hack Night before. Result - Passed

image

ntrehan avatar Aug 12 '24 22:08 ntrehan

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ntrehan-1693 development
git pull https://github.com/ntrehan/VRMS.git 1693

github-actions[bot] avatar Aug 12 '24 22:08 github-actions[bot]

  • @trillium we actually updated the "Hack Night" question in this issue here: https://github.com/hackforla/VRMS/issues/1729 and https://github.com/hackforla/VRMS/pull/1804
  • So, we do need a date picker, however Angela already made this change to the date picker in her PR: https://github.com/hackforla/VRMS/pull/1804

@trillium Please take a look at this PR and make sure that it can be merged given Angela's changes.

JackHaeg avatar Feb 14 '25 01:02 JackHaeg

Per @ntrehan we will run into major merge issues if we were to merge this PR, as additional changes have been made since this PR was submitted. Closing this PR and keeping the issue open for @ntrehan to update the MUI on this component in a fresh PR.

JackHaeg avatar Mar 18 '25 02:03 JackHaeg