VRMS icon indicating copy to clipboard operation
VRMS copied to clipboard

Update HTML to MUI in VRMS/client/src/components/admin/reports /index.js

Open nora-zajzon opened this issue 1 year ago • 4 comments

Fixes #1679

What changes did you make and why did you make them ?

  • Changed all the HTML components to MUI applicable components
Visuals after changes are applied Screenshot 2024-07-24 at 8 20 02 PM

nora-zajzon avatar Jul 25 '24 03:07 nora-zajzon

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b nora-zajzon-index development
git pull https://github.com/nora-zajzon/VRMS.git index

github-actions[bot] avatar Jul 25 '24 03:07 github-actions[bot]

Hey @nora-zajzon, I see that you've taken on multiple tickets as we've gone throught he month of July:

  • #1626
  • #1640
  • #1641
  • #1680

Thanks for taking these on!

It looks like each subsequent PR you're making is including the changes from work on the previous issue (this PR contains changes to 4 files). At the moment it is fine, but please do take care to revert to the development branch for each new PR. It helps us keep changes to the application in smaller chunks so that if there's an issue we can roll back changes in smaller amounts.

Planning on reviewing them in the order that they were submitted :)

trillium avatar Aug 05 '24 21:08 trillium

@trillium Do you still want me to submit a pr for index even though it is not in the current iteration of the app? I do have it locally so I can

nora-zajzon avatar Aug 31 '24 16:08 nora-zajzon

No, if you'd prefer to pass on it you're welcome to. If you'd like to see it through we'll review and accept it :)

trillium avatar Sep 01 '24 16:09 trillium

@nora-zajzon is going to take an action on this. she was unsure if it was important

jbubar avatar Sep 17 '24 02:09 jbubar

Closing this PR due to two being open

nora-zajzon avatar Oct 29 '24 02:10 nora-zajzon