hackforla
Replaced HTML components with MUI applicable components
What changes did you make and why did you make them ?
- Replaced the HTML components with applicable MUI components in ./src/components/auth/HandleAuth.js
- Replaced the HTML components with applicable MUI components in ./src/components/user-admin/EditUsers.js
Want to review this pull request? Take a look at this documentation for a step by step guide!
From your project repository, check out a new branch and test the changes.
git checkout -b nora-zajzon-development development
git pull https://github.com/nora-zajzon/VRMS.git development
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
UI changes to the user edit page:
Screenshots
New
Old
It looks like the MUI list item component renders placeholder text differently than the previous setup, we'll need to go back and fix that in a separate issue.
@JackHaeg can I ping you to track that?
@trillium The new issue tracking the MUI list component fix can be found here: #1723
@trillium Jack told me to ping you on this to try and figure out what happened. So sorry for the inconvenience. I did not realize that this pr was open, and while I was trying to make a different pr, I was having the same issue as before where previous files were added to the commit, despite reverting to the development branch before working on a new branch. I ended up discarding the changes since I did not realize I ever made this pr, which I am assuming close the pr. I am unsure how the force-push happened, and I would like to revert this. Do you know how this could be done? sorry again
@trillium I took a second look at what I force pushed into vrms development, but I do not see any changes in the repo. Correct me if I am wrong, but I think the system “force pushed” my deletes into the pr because at the top of the pr it says “nora-zajzon wants to merge 0 commits into hackforla:development from nora-zajzon:development”. I also looked at both my fork and the repository and neither of them have the changes I had made previously. Do you mind checking to see if this is correct? If so, I don’t think there is anything for us to revert