VRMS icon indicating copy to clipboard operation
VRMS copied to clipboard

Fix display issue with TitledBox in Project Form

Open lcchrty opened this issue 1 year ago • 4 comments

Fixes #1646

What changes did you make and why did you make them ?

  • Placed child components within TitleBox component to properly render the component
  • Bug introduced from previous PR

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

lcchrty avatar Jun 04 '24 01:06 lcchrty

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b lcchrty-lcchrty/issue1646 development
git pull https://github.com/lcchrty/VRMS.git lcchrty/issue1646

github-actions[bot] avatar Jun 04 '24 01:06 github-actions[bot]

@lcchrty just checking in! Would you be able to take a look at the error @Spiteless posted above?

JackHaeg avatar Jun 18 '24 17:06 JackHaeg

In running this I'm getting an error. It looks like isLoading hasn't been defined or passed in as props. Can you take a look?

./src/components/ProjectForm.js
   Line 277:40:  'isLoading' is not defined  no-undef

I'll look into this -- I think some edits from another issue I was working on wormed their way into this PR.

lcchrty avatar Jun 25 '24 02:06 lcchrty

Hey @trilliumsmith, I found the problem! I was working on another ticket that got merged before this one, so there are missing pieces of state and some conditional rendering for the updated save button that isn't showing up. Screenshot below. I'm planning to update this week before our first meeting in August! Screenshot 2024-07-28 at 09 06 16

lcchrty avatar Jul 28 '24 16:07 lcchrty

@trillium merge conflict resolved! CI/CD failing though...

lcchrty avatar Sep 24 '24 22:09 lcchrty

FYI - the failing tests are not an issue with your PR specifically, this has to do with the CI/CD pipeline.

JackHaeg avatar Oct 01 '24 02:10 JackHaeg