Fix display issue with TitledBox in Project Form
Fixes #1646
What changes did you make and why did you make them ?
- Placed child components within TitleBox component to properly render the component
- Bug introduced from previous PR
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied
Want to review this pull request? Take a look at this documentation for a step by step guide!
From your project repository, check out a new branch and test the changes.
git checkout -b lcchrty-lcchrty/issue1646 development
git pull https://github.com/lcchrty/VRMS.git lcchrty/issue1646
@lcchrty just checking in! Would you be able to take a look at the error @Spiteless posted above?
In running this I'm getting an error. It looks like isLoading hasn't been defined or passed in as props. Can you take a look?
./src/components/ProjectForm.js Line 277:40: 'isLoading' is not defined no-undef
I'll look into this -- I think some edits from another issue I was working on wormed their way into this PR.
Hey @trilliumsmith, I found the problem! I was working on another ticket that got merged before this one, so there are missing pieces of state and some conditional rendering for the updated save button that isn't showing up. Screenshot below.
I'm planning to update this week before our first meeting in August!
@trillium merge conflict resolved! CI/CD failing though...
FYI - the failing tests are not an issue with your PR specifically, this has to do with the CI/CD pipeline.