VRMS
VRMS copied to clipboard
Remove ability for PMs to edit Project Information on VRMS
Fixes #1630
What changes did you make and why did you make them?
- Conditionally rendering the edit button (badge) on the project form based on whether or not
auth.user.acessLevel === 'admin'
- If not the user is not an admin, the user should not have the ability to edit the project information but will be able to add and edit events.
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied
Want to review this pull request? Take a look at this documentation for a step by step guide!
From your project repository, check out a new branch and test the changes.
git checkout -b lcchrty-1630-user-project-edit-access development
git pull https://github.com/lcchrty/VRMS.git 1630-user-project-edit-access
@lcchrty Youre going to have to merge dev in now.
@bkmorgan3 Just checking in - are we good to merge this PR?
Thanks @bkmorgan3! 👍
Hey @lcchrty , I believe this PR indroduced a bug.
TitltedBox is supposed to contain children, not be its own closed element
// old
<TitledBox>
{ content }
</TitledBox>
// this PR
<TitledBox />
{ content }
#1646
hey @Spiteless - I picked up the issue for the bug I introduced. thanks for catching* this!
Thanks!
As a reminder it's on the team as a whole to make sure that the code merged works as intended, so no harm done :)
Thanks for picking up the issue!