VRMS icon indicating copy to clipboard operation
VRMS copied to clipboard

Remove ability for PMs to edit Project Information on VRMS

Open lcchrty opened this issue 9 months ago • 1 comments

Fixes #1630

What changes did you make and why did you make them?

  • Conditionally rendering the edit button (badge) on the project form based on whether or not auth.user.acessLevel === 'admin'
  • If not the user is not an admin, the user should not have the ability to edit the project information but will be able to add and edit events.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Screenshot 2024-05-12 at 17 12 47 Screenshot 2024-05-12 at 17 12 58
Visuals after changes are applied Screenshot 2024-05-12 at 17 16 03 Screenshot 2024-05-12 at 17 16 15 Screenshot 2024-05-12 at 17 16 09

lcchrty avatar May 13 '24 00:05 lcchrty

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b lcchrty-1630-user-project-edit-access development
git pull https://github.com/lcchrty/VRMS.git 1630-user-project-edit-access

github-actions[bot] avatar May 13 '24 00:05 github-actions[bot]

@lcchrty Youre going to have to merge dev in now.

bkmorgan3 avatar May 14 '24 04:05 bkmorgan3

@bkmorgan3 Just checking in - are we good to merge this PR?

JackHaeg avatar May 16 '24 21:05 JackHaeg

Thanks @bkmorgan3! 👍

JackHaeg avatar May 16 '24 21:05 JackHaeg

Hey @lcchrty , I believe this PR indroduced a bug.

TitltedBox is supposed to contain children, not be its own closed element

// old 

<TitledBox>
  { content }
</TitledBox>

// this PR

<TitledBox />
{ content }

trillium avatar May 29 '24 23:05 trillium

#1646

trillium avatar May 29 '24 23:05 trillium

hey @Spiteless - I picked up the issue for the bug I introduced. thanks for catching* this!

lcchrty avatar Jun 03 '24 19:06 lcchrty

Thanks!

As a reminder it's on the team as a whole to make sure that the code merged works as intended, so no harm done :)

Thanks for picking up the issue!

trillium avatar Jun 03 '24 19:06 trillium