VRMS icon indicating copy to clipboard operation
VRMS copied to clipboard

remove popup on the close button

Open josiehandeveloper opened this issue 11 months ago • 3 comments

Fixes ##1576

What changes did you make and why did you make them ?

  • When the close button is pressed after the save button the "Wait! you made some changes" popup is removed
  • Initial Fix got rid of the popup, but even when no edits were made on the form and then the close button was pressed - the popup persisted
  • Final fix got rid of the popup after edits were made and the save button followed by the close button were pressed, it also got rid of the popup from the initial fix

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

https://github.com/hackforla/VRMS/assets/63170710/d5c3eb8a-82bd-46cf-a512-8fc13dcd0514

Visuals after changes are applied

https://github.com/hackforla/VRMS/assets/63170710/b98d6fd1-5f7a-42f5-846a-b5695653f2b8

image

josiehandeveloper avatar Mar 19 '24 01:03 josiehandeveloper

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b josiehandeveloper-Edit-on-save development
git pull https://github.com/josiehandeveloper/VRMS.git Edit-on-save

github-actions[bot] avatar Mar 19 '24 01:03 github-actions[bot]

I looked at the development branch to see what styling changes I made but I just changed the onClick portion of the code

josiehandeveloper avatar Apr 02 '24 01:04 josiehandeveloper

It's because we don't have linting across the project at this time (it's in the works). Your linter is formatting the file you're working on when you trigger save probably, which is resulting in a lot of small changes to the code such as changing "thing" --> 'thing' etc. based on the linting rules your workspace has configured.

The file diff has a good representation of what's going on: https://github.com/hackforla/VRMS/pull/1616/files

trillium avatar Apr 02 '24 01:04 trillium