311-data icon indicating copy to clipboard operation
311-data copied to clipboard

Add NC name pill to Search and Filters modal on address selection

Open ryanfchase opened this issue 1 year ago • 1 comments

Overview

We need to render the relevant neighborhood council's name as a pill when the user selects an address so that users know what neighborhood council that address is in.

Action Items

  • [ ] Ensure that address search also selects the NC as a pill (StyledChip)
  • [ ] Ensure that clicking x on the pill will deselect the selected address and reset the zoom level to see all boundaries (e.g. the default zoom level)

Resources/Instructions

v1.2 Moderated Usability Test Slideshow:

Screenshot before proposed changes

image

Screenshot after proposed changes

[insert screenshot here]

ryanfchase avatar Sep 07 '24 06:09 ryanfchase

This ticket is ready for dev lead review -- I'm unsure if this is a Good First Issue. If so, I can add more instruction to support the new dev in completing the ticket.

ryanfchase avatar Sep 07 '24 06:09 ryanfchase

Reviewed and ready for priotization.

traycn avatar Sep 07 '24 18:09 traycn

This ticket has been prioritized and is ready to be picked up 👍

ryanfchase avatar Sep 07 '24 18:09 ryanfchase

Taking this on. Hoping to get it done by Saturday, September 14

Brandoncyu avatar Sep 11 '24 18:09 Brandoncyu

PR is opened: https://github.com/hackforla/311-data/pull/1825

Sending to @ryanfchase and @traycn for review

Brandoncyu avatar Sep 12 '24 19:09 Brandoncyu

Adding my review soon, eta late afternoon. Checking out the branch, the behavior is looking good:

Selecting an address also selects the NC

image

@Brandoncyu for future reference, modify the PR contents so that "issue number here" gets populated. This is the only real requirement for PR issue-formatting for our team at the moment. It becomes a dynamic link and makes it easy to navigate. Thanks.

"Issue number here" location

image

ryanfchase avatar Sep 12 '24 19:09 ryanfchase

Just adding one request for change in my review. Please make the adjustment, or state an alternative approach. Thanks.

ryanfchase avatar Sep 13 '24 04:09 ryanfchase