311-data
311-data copied to clipboard
hackforla
Bugfix: SR RequesetDetail loading spinner not appearing on subsequent mouse-over popups
Overview
We need to fix a bug where the loading spinner on the Service Request inspect modal does not appear on subsequent mouse-overs.
Action Items
In Map.jsx
- [x] Review usage of
<RequestDetail/> - [x] Review usage of
this.requesetDetail - [x] Correct loading behavior of RequestDetail
- [x] Provide SCREEN CAPTURE of the correct behavior
Resources/Instructions
Abbreviations
- Service Request = SR
- Neighborhood Council = NC
Useful Files & Components
- RequestDetail:
components/Map/Map/RequestDetail.jsx - Map:
components/Map/Map.jsx
Mapbox Docs:
- API Reference: https://docs.mapbox.com/mapbox-gl-js/api/
- Popup Example: https://docs.mapbox.com/mapbox-gl-js/example/popup/
Reproducing the Bug
- load the 311 Data site
- select an NC (e.g. Koreatown)
- Mouse-over to one SR 3.1. observe the loading spinner that appears immediately on hover 3.2. take note of the SR Type.
- Move-over to a new SR 4.1. Observe that there is no loading spinner, instead the SR modal is unchanged from step 3 4.2. Observe that the SR modal will quickly re-render with the correct SR information
Click to see finished result
[TODO: VIDEO GOES HERE]
@bphan002 thanks for picking this up. When you can, please leave as a comment:
- ETA
- availability for comment/discussion
ETA: Thursday 10/5 3 PM
Availability: Any time before 2 PM
@bphan002 did you mean 9/5? 🤣
We can always accommodate if you need more time ofc... 😁
I did lol sorry
On Wed, Sep 4, 2024 at 1:56 PM Ryan Chase @.***> wrote:
ETA: Thursday 10/5 3 PM
Availability: Any time before 2 PM
@bphan002 https://github.com/bphan002 did you mean 9/5? 🤣
We can always accommodate if you need more time ofc... 😁
— Reply to this email directly, view it on GitHub https://github.com/hackforla/311-data/issues/1805#issuecomment-2330053250, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATZ7FSXARFO6VMYI4ZYTHZDZU5XY7AVCNFSM6AAAAABNPF742OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZQGA2TGMRVGA . You are receiving this because you were mentioned.Message ID: @.***>
@bphan002 I've left you a review on your PR. Please provide an ETA for addressing the review, thanks!