codepair-old icon indicating copy to clipboard operation
codepair-old copied to clipboard

Change username

Open umi0410 opened this issue 3 years ago • 6 comments

Description: CodePair set the username of each user as a random anonymous name. (e.g. well-made giraffe). If uses can modify their name after getting a random name, it will be useful.

Why: When many people access same document, the names of all users are completely anonymous and random so we can't infer who the anonymous user is in real world.

Supposing there is three members named "David", "Mike", "Sarah", they will get random names like "occasional monkey", "funny puppy", "happy giraffee" on CodePair. In this case, members can't infer who "occasional monkey" is.

umi0410 avatar Aug 10 '21 13:08 umi0410

Hi, I checked this issue and bring some suggestion here. The use case is like this;

  1. User still has anonymous animal name at the first time.
  2. There's a small text input field right next to share button. Anonymous animal name is the default value.
  3. User can change the animal name to whatever they want.
  4. Once Text Input is focus off, Yorkie's UpdateMetadata works and change the user's name.
  5. List Popup of PeerList, PeerListItem will be changed as metadata changed ( => I have to check this point, as I'm not sure UpdateMetadata-related-something in codepair trigger some redux action)

Simple Material UI screenshot below.

ST

TE

Is it acceptable or am I miss something?

shmruin avatar Oct 05 '21 14:10 shmruin

cool

I think It would be nice to be able to change only own name (when user clear on image, open the editable window)

ppeeou avatar Oct 05 '21 23:10 ppeeou

@ppeeou Yes, the user can only change his name. And what do you mean clear on image ? If it means click the image then I guess it may not that helpful; As the images can be overlapped, so if there are too many users, then one cannot click the right image.

shmruin avatar Oct 08 '21 17:10 shmruin

oh sorry I mean click the image How about having own photo always in front?

ppeeou avatar Oct 09 '21 10:10 ppeeou

@ppeeou That sounds reasonable. But it means there would be some tweak in the order of the images. However, I think that's more helpful for the user, so I check that point.

shmruin avatar Oct 09 '21 15:10 shmruin

Hi, I would like to try this issue based on the idea discussed here if that's ok.

doyoonear avatar Jul 15 '22 03:07 doyoonear

You can edit your name in the Settings popup. 스크린샷 2023-04-05 오후 9 09 37

easylogic avatar Apr 05 '23 12:04 easylogic