sprig icon indicating copy to clipboard operation
sprig copied to clipboard

Purge @img tag for all games

Open GalaxyGamingBoy opened this issue 9 months ago • 6 comments

closes #1579

GalaxyGamingBoy avatar Apr 29 '24 11:04 GalaxyGamingBoy

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sprig ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 0:22am

vercel[bot] avatar Apr 29 '24 11:04 vercel[bot]

@GalaxyGamingBoy is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 29 '24 11:04 vercel[bot]

@GalaxyGamingBoy before landing plz look at the plagiarism checker and test-game action failures

grymmy avatar May 01 '24 00:05 grymmy

@JosiasAurel sorry - I tried looking at your requested changes here but the large # of files made it - for one reason or another - somewhat difficult to understand the changes you want on this diff - can u plz ELI5 for me (I am almost definitely missing something)

grymmy avatar May 01 '24 00:05 grymmy

@GalaxyGamingBoy before landing plz look at the plagiarism checker and test-game action failures

Already done w/ Josias, the plagiarism one only works on a single file and the other test failed - because of an error on one game,

GalaxyGamingBoy avatar May 01 '24 06:05 GalaxyGamingBoy

@JosiasAurel sorry - I tried looking at your requested changes here but the large # of files made it - for one reason or another - somewhat difficult to understand the changes you want on this diff - can u plz ELI5 for me (I am almost definitely missing something)

the majority of the files applied the changes. I wanted to make sure that removing the src property on the img tag won't break anything and it hasn't as far as i can tell

JosiasAurel avatar May 01 '24 07:05 JosiasAurel

please resolve conflicts and we can merge!

JosiasAurel avatar May 28 '24 09:05 JosiasAurel