sprig icon indicating copy to clipboard operation
sprig copied to clipboard

use trie-based search in the sprig gallery

Open JosiasAurel opened this issue 1 year ago • 6 comments

The sprig gallery currently has to compare every search query against every game which is very inefficient. A trie-based approach to search will be vastly more efficient than comparing against every game entry.

JosiasAurel avatar Dec 18 '23 15:12 JosiasAurel

I can try on work on this. Would this require creating a trie and putting all the games in it everytime it loads? Or is there a way to store it as a trie in like a global file?

BrightTheBackpack avatar Dec 19 '23 03:12 BrightTheBackpack

@BrightTheBackpack it makes sense to precompute the trie on startup/load and keep a singleton reference to it long-term in memory

grymmy avatar Dec 21 '23 21:12 grymmy

@BrightTheBackpack suggest using a standard/flexible open-source implementation instead of rolling your own - there's quite a few out there

grymmy avatar Dec 21 '23 21:12 grymmy

It's gonna be a little while till I can work on this, me and my family are out on vacation

BrightTheBackpack avatar Dec 22 '23 03:12 BrightTheBackpack

@BrightTheBackpack are you still up to tackle this issue?

JosiasAurel avatar Jan 19 '24 13:01 JosiasAurel

I'm a lite busy right now. If you guys aren't on any hurry i can tackle it in a few weeks. Otherwise, you guys can start if you want

BrightTheBackpack avatar Jan 19 '24 15:01 BrightTheBackpack

I doubt we are doing this. Closing.

grymmy avatar Jun 06 '24 18:06 grymmy