hcb icon indicating copy to clipboard operation
hcb copied to clipboard
verified publisher icon hackclub

[Layouts] DRY up shared code in `application`, `bare`, etc. layouts

Open garyhtou opened this issue 1 year ago • 6 comments

A few of our layouts have duplicated code. This includes the new login layout from https://github.com/hackclub/hcb/pull/9056.

IIRC, Rails has nested layouts. maybe that's something we can use.

garyhtou avatar Jan 03 '25 00:01 garyhtou

Should this be a part of UI3 or maybe after we release that?

manuthecoder avatar Jan 03 '25 00:01 manuthecoder

IIRC, Rails has nested layouts. maybe that's something we can use.

Please!

sampoder avatar Jan 03 '25 01:01 sampoder

Should this be a part of UI3 or maybe after we release that?

separate from UI3!

garyhtou avatar Jan 09 '25 23:01 garyhtou

@manuthecoder, IIRC, you were working on this?

garyhtou avatar Mar 27 '25 17:03 garyhtou

yep! I’ll get this done soon. I was also wondering what the timeline for this looks like, especially since we’re planning to release UI3 in the near future - it might make sense to hold off on this until then. Let me know if you’d prefer I continue with it now though!

manuthecoder avatar Mar 27 '25 19:03 manuthecoder

This can be after UI3— it'll make the merge conflicts easier.

garyhtou avatar Mar 27 '25 22:03 garyhtou