hackclub
Merge receipt bin pair email with upload success email
Summary of the problem
Recently I uploaded a receipt using the receipt bin email on HCB, but was confused when I read the upload success email saying it would be in my receipt bin and it wasn't. Turns out another email has been sent after saying that the receipt had been automatically matched, but it would've been nice for those emails to be merged into one.
Describe your changes
Merged the receipt bin pair email with the upload success email by making it a synchronous suggestion upload method. The @reverse action was also removed as it was already broken and would be difficult to implement if multiple receipts were uploaded in the same email.
The @reverse action was also removed as it was already broken and would be difficult to implement if multiple receipts were uploaded in the same email.
Unfortunately, this is kind of a key feature that I believe we need to continue supporting. Our AI suggestions aren't perfect and I think it would frustrate users if they have to reupload receipts into their receipt bin.
The @reverse action was also removed as it was already broken and would be difficult to implement if multiple receipts were uploaded in the same email.
Unfortunately, this is kind of a key feature that I believe we need to continue supporting. Our AI suggestions aren't perfect and I think it would frustrate users if they have to reupload receipts into their receipt bin.
I talked with Gary about this and he said that we could remove the @reverse action as it already wasn't working and it would take some explaining in the email if you uploaded multiple receipts at once but only wanted to reverse some of them of how to format the command. Another solution to still maintain the reverse pairing functionality would be to include either a link to each pairing in the email that reverses the pairing, or maybe another section in the receipt bin that displays recent pairings and a button to reverse them. What do you think would be best?
New solution after talking with Gary is a button on AI-matched receipts to send it back to the receipt bin (which uses the same reversal method that @reverse did):
I would strongly advocate for the reversal being down via email - this feature is only used by a small subset of users who are trying to avoid the web UI for managing their receipts. I think the link approach seems like the best idea - otherwise it's a lot of clicking through to find that button (though I appreciate that you made it!)
https://github.com/hackclub/hcb/pull/10476#issuecomment-2904573853 Is this only available on receipts added with a suggested pairing? The actual reversal doesn't seem like it involves AI, so I would advocate for enabling it everywhere and using a color that isn't purple.
#10476 (comment) Is this only available on receipts added with a suggested pairing? The actual reversal doesn't seem like it involves AI, so I would advocate for enabling it everywhere and using a color that isn't purple.
+1 that sounds good. I'd also recommend calling it "Move to receipt bin" to make it clearer that the receipt is being removed from this transaction.
Could you spend some time confirming this works as expected when deployed?