dns icon indicating copy to clipboard operation
dns copied to clipboard

added vercel domain verification

Open kumar-kalyan opened this issue 2 years ago • 21 comments

kumar-kalyan avatar Jun 07 '22 16:06 kumar-kalyan

@maxwofford can you help me to merge this

kumar-kalyan avatar Jun 07 '22 16:06 kumar-kalyan

It looks like this removes the verification for hackerabad.hackclub.com. Did you mean to do that? If you want both, you could do something like this:

_vercel:
  ttl: 1
  type: TXT
  values: 
    - vc-domain-verify=hackerabad.hackclub.com,6c3d5d32a250935189d8
    - vc-domain-verify=hackbeats.hackclub.com,5f61f2ff84f3521a0a57

maxwofford avatar Jun 07 '22 17:06 maxwofford

@maxwofford facing some issues with the approach

kumar-kalyan avatar Jun 07 '22 17:06 kumar-kalyan

cc @kunalbotla – i think you were playing with multiple vercel accounts using HC domains.

maxwofford avatar Jun 07 '22 17:06 maxwofford

what should I do now to verify my dns

kumar-kalyan avatar Jun 07 '22 19:06 kumar-kalyan

unfortunately, you can only use vercel with dino.icu domains. you can add the same records you have to that file

kunalbotla avatar Jun 07 '22 19:06 kunalbotla

@kunalbotla so should I host the websit on netlify will that work

kumar-kalyan avatar Jun 07 '22 19:06 kumar-kalyan

yeah that would work

kunalbotla avatar Jun 07 '22 19:06 kunalbotla

hi @kunalbotla and @kum9748ar! actually vercel does support multiple accounts for one domain now; i updated the readme with the instructions. i think what max put here https://github.com/hackclub/dns/pull/702#issuecomment-1148938535 is correct

maggie-j-liu avatar Jun 08 '22 16:06 maggie-j-liu

@maggie-j-liu can you link me to that? we have a custom configuration with vercel on dino.icu that allowed it, but not on the others for security reasons.

edit: saw the link

kunalbotla avatar Jun 08 '22 16:06 kunalbotla

@maggie-j-liu & @kum9748ar, that's for transferring a domain's ownership. if you were to add that record, it would remove hackclub.com from Hack Club's Vercel account. dino.icu is the domain configured as an eTLD for Vercel

kunalbotla avatar Jun 08 '22 16:06 kunalbotla

hii @kunalbotla i've tested this and it's not the case... it doesn't transfer the domain; it just delegates a subdomain to another account. you're able to get the subdomain back if you ever need to use it by removing the verification record

maggie-j-liu avatar Jun 08 '22 16:06 maggie-j-liu

@maggie-j-liu could you point me to where they say that?

kunalbotla avatar Jun 08 '22 16:06 kunalbotla

it doesn't say that it will transfer the domain to the other account...

If the domain is in use by another Vercel account, you may be prompted to verify access to the domain.

verify access doesn't mean transfer to another account?

i'm happy to open a pr and add a subdomain to hackclub.com as an example

maggie-j-liu avatar Jun 08 '22 16:06 maggie-j-liu

@maggie-j-liu that'd be helpful for testing! that way we can also check that removing the verification TXT record removes the subdomain from Vercel immediately.

maxwofford avatar Jun 08 '22 16:06 maxwofford

in my testing, removing the verification record does not remove the subdomain. however, if you then add the subdomain to your own account and add your own verification record, then the subdomain on the other account will stop working

maggie-j-liu avatar Jun 08 '22 16:06 maggie-j-liu

@maxwofford @kunalbotla @maggie-j-liu can I get a feedback on my last commit

kumar-kalyan avatar Jun 08 '22 16:06 kumar-kalyan

@maggie-j-liu I don't want to test this in production. let me reach out to Vercel to see if they have any information.

kunalbotla avatar Jun 08 '22 16:06 kunalbotla

Hey can I get a feedback on this

kumar-kalyan avatar Jun 23 '22 18:06 kumar-kalyan

Unable to verify domain at vercel

kumar-kalyan avatar Jun 23 '22 18:06 kumar-kalyan

@kumar-kalyan @maggie-j-liu @maxwofford @kunalbotla, following up on this PR. Should it be closed?

sampoder avatar Oct 25 '22 06:10 sampoder