hackchat-client icon indicating copy to clipboard operation
hackchat-client copied to clipboard

Published 20 hours ago • verified publisher icon hack-chat

Implement local storage handling

Open marzavec opened this issue 4 years ago • 4 comments

Local storage should be used to save the users nick and password, along with other settings ( #12 ). This data should be loaded into the redux store when the app starts. This may also tie into #6

marzavec avatar Dec 14 '20 17:12 marzavec

The data in local storage could be accessed by different users if the computer is shared. How can we ensure the sensitive portion of the stored data is cleared when a user is finished using hack.chat?

henrywright avatar Dec 15 '20 14:12 henrywright

I have seen this concern raised a few times in the past, because this is the same behavior that the legacy client uses. There are very few options available to address the concern. Do you have any suggestions?

marzavec avatar Dec 15 '20 14:12 marzavec

In my opinion I wouldn't store sensitive information in local storage but if the legacy client does this currently then we could implement a clearing mechanism to ensure the data is deleted

The data could be automatically deleted when the user closes hack.chat or alternatively a button could be provided for the user to click. I'm not sure which approach is best. What are your thoughts?

henrywright avatar Dec 15 '20 15:12 henrywright

Since this is a different issue, I've opened up a different case, #28 where we can discuss it further.

marzavec avatar Dec 15 '20 16:12 marzavec