synologydsm-api icon indicating copy to clipboard operation
synologydsm-api copied to clipboard

Published 20 hours ago • verified publisher icon hacf-fr

Add Hyper Backup

Open mib1185 opened this issue 4 years ago • 7 comments

This PR will add Hyper Backup related functionalities. This first version only contains read actions, because of missing api documentation, implementation of write functions needs more time to evaluate how the backup api works.

mib1185 avatar Dec 02 '20 17:12 mib1185

Do you think you can add some typing on all these new methods?

tetienne avatar Dec 04 '20 08:12 tetienne

@tetienne thanks for your feedback ... of course, add typing is a good idea 👍

mib1185 avatar Dec 04 '20 19:12 mib1185

@mib1185 Sorry, but you know have to rewrite your tests.

tetienne avatar Dec 18 '20 12:12 tetienne

@mib1185 Sorry, but you know have to rewrite your tests.

@tetienne No problem ... I have fixed the conflict

mib1185 avatar Dec 19 '20 17:12 mib1185

@tetienne sorry for very late response, but this PR was fully out of my mind 🙈 Not sure why the safety check fails 🤔

mib1185 avatar Feb 01 '21 20:02 mib1185

Needs to be rebased after #11 is merged.

mib1185 avatar Mar 05 '21 12:03 mib1185

What needs to be done to get this merged? @mib1185 or @tetienne

catchdave avatar Oct 18 '22 21:10 catchdave