doric icon indicating copy to clipboard operation
doric copied to clipboard

feat: [+] decimal round with mode & (array) mkString functions

Open eruizalo opened this issue 1 year ago • 2 comments

Description

(relatively ) new doric functions:

  • Array[String] columns:
    • there is now a function called mkString like scala. Actually it is the concat_ws function from spark.
  • Decimals columns:
    • there is now a round function which lets you choose the round mode given a number of decimals

Related Issue and dependencies

  • Resolves N/A
  • Depends on N/A

How Has This Been Tested?

  • This pull request contains appropriate tests?:
    • YES

eruizalo avatar May 09 '23 14:05 eruizalo

:octocat: This is an auto-generated comment created by:

  • Date : 2023-11-07 13:04:33 +0000 (UTC)
  • Workflow : PR comment
  • Job name : create_test_summary_report
  • Run : 6784894058
  • Commit : 9fb606e1e647d2ab9c0a18c7455e69ab1fefb61b fix: testing
Actor Triggering actor Sender
eruizalo
eruizalo
eruizalo
eruizalo
eruizalo
eruizalo
Triggered by:

Test summary report 📊

Spark version testing
3.0.0 685 passed, 2 skipped
3.0.1 685 passed, 2 skipped
3.0.2 685 passed, 2 skipped
3.0 685 passed, 2 skipped
3.1.0 713 passed, 2 failed, 2 skipped
3.1.1 713 passed, 2 failed, 2 skipped
3.1.2 713 passed, 2 failed, 2 skipped
3.1 713 passed, 2 failed, 2 skipped
3.2.0 719 passed, 2 skipped
3.2.1 719 passed, 2 skipped
3.2.2 719 passed, 2 skipped
3.2 719 passed, 2 skipped
3.3.0 719 passed, 2 skipped
3.3.1 719 passed, 2 skipped
3.3 719 passed, 2 skipped
3.4 719 passed, 2 skipped

github-actions[bot] avatar May 09 '23 14:05 github-actions[bot]

Codecov Report

Merging #354 (9fb606e) into main (6aeb249) will decrease coverage by 0.22%. The diff coverage is 70.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
- Coverage   97.69%   97.47%   -0.22%     
==========================================
  Files          62       62              
  Lines        1255     1264       +9     
  Branches       37       33       -4     
==========================================
+ Hits         1226     1232       +6     
- Misses         29       32       +3     
Flag Coverage Δ
spark-3.0.x 96.48% <50.00%> (-0.24%) :arrow_down:
spark-3.1.x ?
spark-3.2.x 97.67% <100.00%> (+0.01%) :arrow_up:
spark-3.3.x 97.67% <100.00%> (+0.01%) :arrow_up:
spark-3.4.x 97.67% <100.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ore/src/main/scala/doric/syntax/ArrayColumns.scala 100.00% <100.00%> (ø)
...e/src/main/scala/doric/syntax/NumericColumns.scala 100.00% <ø> (ø)
..._3.3_3.4/scala/doric/syntax/NumericColumns32.scala 100.00% <100.00%> (ø)
....0_3.1/scala/doric/syntax/NumericColumns2_31.scala 76.92% <0.00%> (-23.08%) :arrow_down:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6aeb249...9fb606e. Read the comment docs.

codecov[bot] avatar Aug 15 '23 10:08 codecov[bot]