habitat

habitat copied to clipboard

Cannot `hab config apply` when ring key is in use

4

Environment Details: - Ring consists of 6 nodes running as dedicated supervisors service group and 4 nodes running as a `customer_portal.prod` service group. - All nodes show that they joined...

cwebberOps

Reconsider how we determine if a process is "alive" on Linux

2

Our [is_alive](https://github.com/habitat-sh/core/blob/22f09fc7ca4e8dd87a655cd2186eff1c20d6eea9/components/core/src/os/process/linux.rs#L74-L83) function is essentially a fancy version of the [libc::kill](http://man7.org/linux/man-pages/man2/kill.2.html). As such, it cannot distinguish between a process that exists and is alive, and a process that exists but...

christophermaier

Replace `hostname()` function in favor of `dns_lookup::lookup_host()`

2

Habitat already have a function that returns the hostname of the machine[ called `hostname()`](https://github.com/habitat-sh/habitat/blob/master/components/core/src/os/net/windows.rs#L22), we could explore the possibility of refactoring that function and replace it for [`dns_lookup::lookup_host()`](https://docs.rs/dns-lookup/1.0.0/dns_lookup/index.html#lookup_host)

afiune

Add a utility function for dealing with required/expected Clap arguments

2

Frequently, our Clap argument processing code has many `unwrap()` calls, because the argument/option in question is either required, or has a default value, meaning we can safely assume there will...

christophermaier

Cache EnvConfig-mediated values

2

Any configuration variables controlled by our [EnvConfig](https://github.com/habitat-sh/habitat/blob/7e26824974aa50556fe477ee1acbc3d2aa1a38d8/components/common/src/types/env_config.rs) abstraction emit log messages whenever they are overridden by their "undocumented" environment variables. This is very useful to provide visibility whenever something is...

christophermaier

Consolidate Supervisor filesystem pathing code

2

We have code for determining the appropriate filesystem paths for several parts of the Supervisor, split across several locations. For consistency, we should consolidate all these. For example: - [FsCfg](https://github.com/habitat-sh/habitat/blob/f9a3c3156a24abcf9f8884400a58534858274baf/components/sup/src/manager/mod.rs#L113-L129)...

christophermaier

Documentation for pkgPathFor is incorrect

4

The documentation for pkgPathFor (https://www.habitat.sh/docs/reference/#pkgpathfor-helper) says: > Returns the absolute filepath to the package directory of the package best resolved from the given package identifier. The named package must exist...

stevendanna

Add make targets for shellcheck, rustfmt, and a "test everything before I push"

4

It would be nice to have make targets that run `test/shellcheck.sh`, `support/ci/rustfmt.sh`, and one to test several things that are tested in the CI build. This would be useful to...

davidMcneil

Send health check events on a separate NATS subject

2

Since health checks are currently the most frequently sent event for our Automate integration, it can simplify processing on the Automate side if they can subscribe to a single subject...

christophermaier

Provide clearer messaging from Get-SupervisorLog when supervisor is not running in a local windows studio

1

Under some circumstances when the supervisor is not running in a local windows studio, the log window appears and then quickly disappears, which is very confusing. This either means that...

mwrock