Habib Alkhabbaz
Habib Alkhabbaz
> @habibalkhabbaz I'm modifying `app/cronjob/trailingTrade/step/ensure-grid-trade-order-executed.js`. I simply added `const queue = require('../../trailingTradeHelper/queue');` and then later in code I used `queue.executeFor(logger, symbol);`, but it's throwing `TypeError: queue.executeFor is not a function`....
> @chrisleekr If it's not throwing the error for you, then you can merge, but for me it's logging this when buy order is filled: > > `{"name":"binance-api","version":"0.0.88","hostname":"2fb1d3018816","pid":46,"gitHash":"unspecified","level":50,"err":{"message":"p.executeFor is not...
That's great @uhliksk If no more issues I think this PR will be ready to be reviewed by @chrisleekr Do you agree @uhliksk?
@uhliksk To be honest, I am not sure from where the issue is coming. Can you log `symbols` just before `forEach` to see what's happening?
@uhliksk Okay, I think I found the issue. The `queue` cannot be referenced inside the trailing trade steps. It should be in anywhere else because the `queue` has reference to...
@uhliksk You are right. So, here is a draft of what I suggest. After an order is executed it should do the following. ``` if (exceeded the max open trades)...
@uhliksk Yes. Let me know if you need any help in the implementation, I will be happy to work on this too.
> @habibalkhabbaz You can actually move the `cancelOrder` by yourself as I can't commit the change with the tests failing. Okay, let me work on this.
@uhliksk Done. I moved `cancelOrder` to common and I updated `handle-open-orders` accordingly.
@uhliksk I think you have to merge the last commit by @chrisleekr from the master branch.