sac icon indicating copy to clipboard operation
sac copied to clipboard

paper/code conflict: using minimum Q in policy gradient

Open jpreiss opened this issue 7 years ago • 1 comments

The Soft Actor-Critic paper (arXiv v2) says, in the last paragraph on page 5:

We then use the minimum of the Q-functions for the value gradient in Equation 6 and policy gradient in Equation 13

However, the code in sac/algos/sac.py uses only one of Q functions in the policy gradient loss. It does use the minimum in the value gradient loss.

Is there a reason for the discrepancy? Thanks!

jpreiss avatar Aug 16 '18 00:08 jpreiss

Good catch! We actually tried both versions and did not find much difference between them. We'll fix the code in the next release.

haarnoja avatar Aug 24 '18 19:08 haarnoja