Graham Knop

I agree with your concerns about checking the scalar type, but given that it's already used, exposing it as a set of functions doesn't seem unreasonable. And for your use,...

This is meant to be an optimization, so I'm not sure of a good way to test it. For a demonstration of the impact it has though: ``` $ cat...

I should also add that we ran into this problem when using the [ValuesAndExpressions::ProhibitDuplicateHashKeys](https://metacpan.org/pod/Perl::Critic::Policy::ValuesAndExpressions::ProhibitDuplicateHashKeys) critic policy on files with large hashes.

No, it doesn't. The cached position is always checked before being used, so it doesn't need to be invalidated on modifications. Validating the position doesn't slow anything down, so this...

I guess it's worth pointing out that this could slow down iteration in some specific cases. If you are only iterating through a small number of siblings at the start...

It seems confusing if setting x_authority: "cpan:HAARG" started copying a bunch of other permissions. Would we just be ignoring the value entirely?

That interface also appears to only be available to PAUSE admins. Is having 2500 permissions a significant problem somewhere? And for most dists there wouldn't be anywhere near that many.

> Why is v5.11 the cut-off point? `use v5.10;` already had semantic effects like enabling `state` or `say`. Yeah, I was wrong here. I was thinking about strict, which wasn't...

I've updated this to only allow versions before 5.10, but also it now only checks that the previous version is < 5.10. So `use v5.8; use v5.12;` is allowed.

This warning was from PR #21915