Encourage icon indicating copy to clipboard operation
Encourage copied to clipboard

Eta for Visual Studio 2022 Support

Open user1568891 opened this issue 4 years ago • 4 comments

Would love to see this for Visual Studio 2022. Currently it won't let me install to it.

user1568891 avatar Nov 12 '21 21:11 user1568891

Going to attempt a PR to support 2022, stay tuned :)

CalvinAllen avatar Nov 18 '21 15:11 CalvinAllen

@haacked - I've got the project restructured to support this, but running into issues getting the 2022 version to work.

Almost all of the core code has been moved into a Shared project, and is referenced by a project targeting x86 (this is the original version), and a new x64 project. The x86 version seems to (still) work fine in AT LEAST 2017 and 2019 (I no longer have access to any older than that). x64 seems to install into 2022, but never fires on save, nor is the settings dialog page available.

I'm out of my depth troubleshooting it, since I'm not familiar with the SDKs you're using / needed, nor interacting with the editor. Seems like something might have changed between 2019 and 2022 that is causing it, but I'm not sure. Might need to see if somebody else can help on that part.

You'll have to deploy two versions of the extension with the changes, one for everything up to 2019, and another for 2022+.

CalvinAllen avatar Nov 25 '21 23:11 CalvinAllen

LOL, I said that and then immediately figured out the issue. Of course.

The new project, even though it was a VSIX, wasn't really doing any VSIX "stuff". Now it seems to be working okay!

CalvinAllen avatar Nov 25 '21 23:11 CalvinAllen

Just upgraded to VS 2022 and didn't see it available in the extension manager. Did this ever get pushed to the marketplace for 2022?

pmcintyre3 avatar Feb 02 '22 18:02 pmcintyre3

bump! Any progress on getting this ~~installed~~ pushed to the marketplace?

pmcintyre3 avatar Dec 12 '22 19:12 pmcintyre3

I forked and published the 2022 version -

https://marketplace.visualstudio.com/items?itemName=coding-with-calvin.Encourage-x64

Hopefully Phil doesn't mind, but if you do, let me know and I can transfer the marketplace listing to you, or remove it, whatever :)

CalvinAllen avatar Apr 13 '23 19:04 CalvinAllen

Nice!! I actually built it locally and installed it. But I'll definitely use this listing for the next time I build a new environment. Thank you!

pmcintyre3 avatar Apr 13 '23 19:04 pmcintyre3

I've taken down my version of the 2022 extension.

Phil has given me access to this repo and his publisher on the marketplace, so we're going to get everything updated and published there!

CalvinAllen avatar Apr 14 '23 15:04 CalvinAllen

And we are done!

2012-2019 version is here - https://marketplace.visualstudio.com/items?itemName=Haacked.Encourage

2022 (and up?) version is here - https://marketplace.visualstudio.com/items?itemName=Haacked.Encourage-22

Officially closing issue 🎉🥳🎈🎊🍾

CalvinAllen avatar Apr 16 '23 01:04 CalvinAllen

Thank you!

haacked avatar Apr 16 '23 01:04 haacked

Thank you @CalvinAllen and @haacked!

user1568891 avatar Apr 18 '23 14:04 user1568891