Piotr Jastrzębski

Results 142 comments of Piotr Jastrzębski
trafficstars

Probably we should generate an insert when there are no regular columns.

so can this issue be closed then? @tzach @avelanarius ?

What is needed to merge this? @jinzhu Could you have a look please?

> I'll be blunt: this is a _bad_ idea. > > The API is fine, although I'm partial to just adding a `func OpenConn(conn gorm.ConnPool)` and be done with it....

If you decide to do your own "clone" @ytsruh you can take inspiration in https://github.com/ncruces/go-sqlite3/blob/main/gormlite/sqlite.go

Positional parameters work already. We will work on named parameters in the near future.

Replication is async so it shouldn't impact the performance. This is something we will have to debug to understand why replication has such a big impact on performance.

This is sort of expected. Turso multi database schema migrations are asynchronous. User has to call special API to wait for the migration to finish. I doubt Goose does that.

That's not the way it works. The call registers update tasks for all databases and then returns. The parent db is updated last. I don't think this is a transaction...