Hongxiang Jiang

Results 97 comments of Hongxiang Jiang

Let me give it a try. I have never used the go.cmd or go.ps1 and I normally don't do any development in Windows, I will need to see whether this...

Thanks for raising this, I think the problem you encountered is how the go binary is built using dlv. ``` ../../c/cpackage/cpackage.go:15:7 (Compilation error). ``` apparently is a relative path, relative...

Sorry I forgot to follow up, based on the comments above, I think it is the relative path issue. I will label this issue `NeedsInvestigation`, I'm not a dlv expert...

Hi @ccoVeille Thank you for reporting this, I recently made some changes to format tool but I hope I did not interrupt your current behavior. Could you share the exact...

Hi @iacore I have never tried to use goimports-reviser ever. But vscode does not provide the file path to formatter, the extension provide the file content to the formatter through...

@ccoVeille , let me follow up on #3906.

Hi iacore@ Thanks @ccoVeille , you are providing the right configs (flags) to allow goimports-reviser to accept stdin. But it turns out the extension is not passing the file content...

I'm glad this is the root cause of the problem. :D If that patch can merge, we can close this as unplanned.

Thanks for reporting this, I did no catch this in the first place. Really appreciate it! Most of the code generation is defined in [addtest.go](https://go.googlesource.com/tools/+/refs/heads/master/gopls/internal/golang/addtest.go). Particularly, we go through the...

It is not my original idea but I hope this would be shared here in case it helps. Writing test for un-exported functions increase the test coverages but sometimes is...