moodle-mod_hvp icon indicating copy to clipboard operation
moodle-mod_hvp copied to clipboard

Published 20 hours ago • verified publisher icon h5p

Editor breaking when installing new content type

Open bkasel opened this issue 2 years ago • 1 comments

environment: php 8.0 moodle 4.0.2 hvp-plugin:1.22.3 and 1.22.4 tested in multiple browsers

When creating a new h5p activity instaling a new content type fails (clicking get and then install in th editor), the editor breaks and disappears. The following error is displayed in the browser js console.

grafik

bkasel avatar Aug 19 '22 22:08 bkasel

The error was remedied by changing to php version 7.4. It seems that the editor is not php 8.0 compatible yet.

bkasel avatar Aug 22 '22 14:08 bkasel

Hey there! 👋🏻

I'm facing the same issue. Is there any workaround for it?

DmitrySharabin avatar Jan 07 '23 13:01 DmitrySharabin

El plugin H5P en Moodle, se cuelga instalando "tipo de contenido", SOLUCION, Usar php 7.4

cairiza avatar Jan 20 '23 20:01 cairiza

changing to php version 7.4.

cairiza avatar Jan 20 '23 20:01 cairiza

Estimados, no es necesario cambiar de versión de PHP. Es un problema de permisos de archivos que se arregla cambiando algunas líneas del: ./mod/hvp/classes/framework.php

En adjunto se los envío. Los cambios están indicados con "MARCA". Saludos. +Andrés

framework.php (https://github.com/h5p/moodle-mod_hvp/files/10564748/framework.php.patch)

ing-andres-lopez avatar Feb 02 '23 04:02 ing-andres-lopez

I confirm the patch proposed by ing-andres-lopez works but it would be great to apply it to the main project because PHP 7.4 is no more supported. https://www.php.net/supported-versions.php

zabellemotte avatar Mar 30 '23 11:03 zabellemotte

Estimados, no es necesario cambiar de versión de PHP. Es un problema de permisos de archivos que se arregla cambiando algunas líneas del: ./mod/hvp/classes/framework.php

En adjunto se los envío. Los cambios están indicados con "MARCA". Saludos. +Andrés

framework.php (https://github.com/h5p/moodle-mod_hvp/files/10564748/framework.php.patch)

Excelente. funcionó perfectamente. / Great, it works!

Muchas gracias / Thank you.

fjrojast avatar Apr 20 '23 00:04 fjrojast

I only commented these line

https://github.com/h5p/moodle-mod_hvp/blob/a1a2fa818ff108b9924e04ffa0f7d425a951c69b/classes/framework.php#L247

Obviusly my directories permissions is correctly setted.

YisusCore avatar May 04 '23 23:05 YisusCore

I believe that this is the same issue as mentioned here: https://github.com/h5p/moodle-mod_hvp/issues/471

The patch attached to that ticket should fix the issue you're experiencing: https://github.com/h5p/moodle-mod_hvp/pull/472

benfes avatar May 23 '23 20:05 benfes

Fixed by #472 will release an updated plugin asap.

icc avatar May 26 '23 13:05 icc

If you want to make the mimimal maintenance for this plugin, it would be great to integrate the Moodle 4 new icon. It is only 2 lines to modify. https://docs.moodle.org/dev/Moodle_4.0_developer_update#Activity_icons

zabellemotte avatar May 30 '23 12:05 zabellemotte