moodle-mod_hvp icon indicating copy to clipboard operation
moodle-mod_hvp copied to clipboard

Cannot change from library to another and "paste & replace" doesn't work at all

Open Urpokarhu1 opened this issue 2 years ago • 14 comments

Hello,

It seems that

  • "Paste & replace " from course presentation to course presentation
  • and
  • changing one library to another f.ex from course presentation doesn't work at all and just loads forever.

Tested with Moodle 3.9.12 & mod_hvp 1.22.4. With mod_hvp 1.22.3 everything works.

Urpokarhu1 avatar May 18 '22 10:05 Urpokarhu1

@thomasmars

Urpokarhu1 avatar May 18 '22 10:05 Urpokarhu1

@Urpokarhu1 The latter sounds like a recent problem in editor H5P core (not in the plugin) and was fixed already in https://github.com/h5p/h5p-editor-php-library/commit/f712ee5963c2904eba6c993bc8c430c327f0d07f. The other one most likely is also not a problem with the plugin, but with the H5P editor core (or maybe Course Presentation, hard to tell without proper description of the issue)

otacke avatar May 18 '22 10:05 otacke

@Urpokarhu1 Or: it's actually the same issue that was fixed with the other fix (If you mean 1. copy a course presentation from within the H5P Hub, 2. immediately afterwards paste it to the Hub to create a copy of that content)

otacke avatar May 18 '22 10:05 otacke

Hello,

Thanks for the info, when will mod_hvp 1.22.5 will be available so we benefit from the fix?

Urpokarhu1 avatar May 18 '22 10:05 Urpokarhu1

@Urpokarhu1 I don't know. I am not a member of the H5P core team.

otacke avatar May 18 '22 10:05 otacke

@thomasmars you might have an idea?

Urpokarhu1 avatar Jun 20 '22 09:06 Urpokarhu1

I have created an issue for looking into this in the H5P issue tracker: https://h5ptechnology.atlassian.net/browse/HFP-3532. You can follow the progress there.

thomasmars avatar Jun 20 '22 10:06 thomasmars

The loading forever bug also happens when trying to paste & replace an instance of Interactive Book.

Using Moodle 3.11.10, mod_hvp 1.22.4, and Interactive Book 1.6.4.

Should I update the Jira ticket with this information @thomasmars?

wilenius avatar Oct 13 '22 08:10 wilenius

@wilenius That should be true for all content types, so I don't think changing the ticket makes much sense.

otacke avatar Oct 13 '22 08:10 otacke

FYI, It's not happening for all content types. I tested pasting an Accordion and it worked without a hitch.

wilenius avatar Oct 13 '22 08:10 wilenius

@wilenius The bug was present for all content types, but if I recall correctly it would only show when the same libraries were attempted to be loaded multiple times. Since Accordion doesn't have any dependencies with overlapping depencies, you won't notice anything.

otacke avatar Oct 13 '22 09:10 otacke

Ok, thanks for letting me know @otacke! So there's a fix already?

wilenius avatar Oct 13 '22 09:10 wilenius

@wilenius See previous post on this very issue ;-) https://github.com/h5p/moodle-mod_hvp/issues/446#issuecomment-1129848479

otacke avatar Oct 13 '22 09:10 otacke

Thank you and sorry! 🤦

wilenius avatar Oct 13 '22 09:10 wilenius