moodle-mod_hvp
moodle-mod_hvp copied to clipboard
Cannot change from library to another and "paste & replace" doesn't work at all
Hello,
It seems that
- "Paste & replace " from course presentation to course presentation
- and
- changing one library to another f.ex from course presentation doesn't work at all and just loads forever.
Tested with Moodle 3.9.12 & mod_hvp 1.22.4. With mod_hvp 1.22.3 everything works.
@thomasmars
@Urpokarhu1 The latter sounds like a recent problem in editor H5P core (not in the plugin) and was fixed already in https://github.com/h5p/h5p-editor-php-library/commit/f712ee5963c2904eba6c993bc8c430c327f0d07f. The other one most likely is also not a problem with the plugin, but with the H5P editor core (or maybe Course Presentation, hard to tell without proper description of the issue)
@Urpokarhu1 Or: it's actually the same issue that was fixed with the other fix (If you mean 1. copy a course presentation from within the H5P Hub, 2. immediately afterwards paste it to the Hub to create a copy of that content)
Hello,
Thanks for the info, when will mod_hvp 1.22.5 will be available so we benefit from the fix?
@Urpokarhu1 I don't know. I am not a member of the H5P core team.
@thomasmars you might have an idea?
I have created an issue for looking into this in the H5P issue tracker: https://h5ptechnology.atlassian.net/browse/HFP-3532. You can follow the progress there.
The loading forever bug also happens when trying to paste & replace an instance of Interactive Book.
Using Moodle 3.11.10, mod_hvp 1.22.4, and Interactive Book 1.6.4.
Should I update the Jira ticket with this information @thomasmars?
@wilenius That should be true for all content types, so I don't think changing the ticket makes much sense.
FYI, It's not happening for all content types. I tested pasting an Accordion and it worked without a hitch.
@wilenius The bug was present for all content types, but if I recall correctly it would only show when the same libraries were attempted to be loaded multiple times. Since Accordion doesn't have any dependencies with overlapping depencies, you won't notice anything.
Ok, thanks for letting me know @otacke! So there's a fix already?
@wilenius See previous post on this very issue ;-) https://github.com/h5p/moodle-mod_hvp/issues/446#issuecomment-1129848479
Thank you and sorry! 🤦