Critical bug; Grade to pass doesn't work in Moodle!

[Jarvil]

Hello,

Grade to pass -setting doesn't work in interactive video, moodle course completion report shows the activity completed (did not achieve pass grade) but you still get the "course complete" -mark.

steps to repeat;

1. Create interactive video
2. Add two true/false questions
3. Do not add any statements on 3. Summary -page.
4. Set grade to pass 10.00 and check that maximum grade is 10.00
5. Save
6. Do the activity as a student and only get one true/false question right (and by so getting grade 5.0/10.0)
7. Open course completion and notice how student will get "course completed" marking.

tested on Moodle 3.3.2 & Mod_hvp 1.6

[Jarvil]

This seems pretty critical error to me @timothyylim @ReneBreedveld

[Jarvil]

This seems pretty critical to mee @falcon-git

[Jarvil]

Grade to pass is new feature in H5P 1.6 so I can't test this with 1.5 version. I have tested this in two separate Moodle installations (3.3.2 and 3.3.3 & mod hvp 1.6) and it concerns them both.

[Jarvil]

This seems to concern mod_hvp 1.7 also.

[thomasmars]

Hi, Your course activities completion criterias can be set up completely separate from your course completion criterias, so there is not necessarily any correlation between the activity completion and course completion, this is completely up to the course administrator to configure in the course completion settings.

The behaviour you're experiencing is the expected one, and I'll try to explain why. If I understand correctly you have set up that for a course to be completed the "Condition: Activity completion" is set with the Interactive Video content type checked.

Next, if you look under "Activity completion" for the Interactive Video, you have most likely checked "Require grade: Student must receive a grade to complete this activity". Note that the student only needs to receive a grade to complete the activity, not an actual passing grade to complete it. Pass and fail icons will be displayed in the course report to complement the course completion, so that a teacher can decide whether the course was completed and passed or completed and failed.

If you want course completion to be affected by grades you can set up the "Condition: Course grade" option in course completion settings, which will allow you to determine a total score for the course which must be passed in order to get it completed.

If you want a new "Activity completion" criteria, we would have to add an option, next to "require grade" in the Interactive Video activity, saying "require passing grade", which I suspect is the functionality you're looking for ?

[Jarvil]

Hello,

Yes that is the case, course is completed when H5P-activity is completed. Why does H5P-activity have then "grade to pass" setting if it's useless/pointless since there is no "require passing grade" setting under activity completion?

[thomasmars]

I would argue that the setting is not useless, as it serves to show whether the activity was passed or not in the course report (a tick or a red cross), as I tried to point out "completing" and "passing" are two distinctly different statuses. This is how Moodle works, and is actually not unique to H5P.

However, I do agree that having a "require passing grade" option would enhance the difference between completion and passing, as I recognize that the option is quite vague and can be confusing in this case.

[Jarvil]

Thanks for the clarifcation, it seems it's not completely useless. I have already posted in the past a feature request about adding "require passing grade" to H5P-actitivites but I don't know if it's on the roadmap;

https://h5p.org/node/93091

[thomasmars]

Thank you, I've added a new issue for this in the public issue tracker : https://h5ptechnology.atlassian.net/browse/HFP-1853 Feel free to add any additional comments there, hopefully we can prioritize it soon.

[Jarvil]

Hello,

Great, thank you 👍

[falcon-git]

@Jarvil Initially this seemed critical to me as well. When digging I can see why it was designed the way it is. Moodle actually knows that the activity was failed. The user completed the activity and failed or the user completed the activity and succeeded is what we tell Moodle. Makes sense. Would have wished that Moodle could require that activities passed in order to lock up new activities, issue certificates or complete courses, but complete seems to be the main status Moodle considers. We're not super experienced with Moodle yet, so all feedback of this kind is very valuable. We're estimating how long it will take to fix this now, and will do a hotfix if we don't think it takes too long. A Hotfix means it probably goes out on Monday. Not hotfix means the fix will be there next time we do an ordinary update of the Moodle plugin.

[falcon-git]

Moodle's built in Quiz has code everywhere to support this feature, the completion API doesn't have built in support for it. We do it in the beginning of the next sprint, hopefully in the beginning of March.

[Jarvil]

Hello,

Great, I'm looking forward to it.

[Jarvil]

Hello,

I don't see any progress on (I also tested in mod_hvp 1.8 but grade to pass still doesn't work as expected)

https://h5ptechnology.atlassian.net/browse/HFP-1853

@falcon-git @thomasmars

[thomasmars]

Hi @Jarvil, We have not been able to prioritize this yet unfortunately. We are happy to accept a pull request for this.

[Jarvil]

Hello,

This issue still persists in mod_hvp 1.11 and is quite misleading when you have "grade to pass" and "maximum grade" settings in the H5P-activity settings but no "require passing grade" -option.