h5p-interactive-video icon indicating copy to clipboard operation
h5p-interactive-video copied to clipboard

Published 20 hours ago • verified publisher icon h5p

Add volume slider to mute button

Open camvrgs opened this issue 4 years ago • 4 comments

Addresses Issue #160 , adds a vertical volume slider to the mute button, which updates the video volume level using setVolume (available in all handlers of H5P.Video).

camvrgs avatar Dec 28 '20 20:12 camvrgs

@camvrgs Very cool addition! Thanks! I hope the H5P core team will find time to take a look at this pull request soon.

The one thing that they'll probably comment on is accessibility, as you can neither access the slider with the keyboard (you now have ) nor is it announced via readspeakers. You might want to check on YouTube how it's done there, maybe that's an option here as well.

otacke avatar Dec 29 '20 13:12 otacke

@otacke Great suggestion, you're right that would make it more of a complete solution. I'll take another look, thanks!

camvrgs avatar Dec 31 '20 15:12 camvrgs

Hey everyone. Is this project inactive? It would be amazing if we could merge this!

Nugatp avatar Jul 15 '21 09:07 Nugatp

Hi! I came looking here after getting fed up with the lack of a slider while watching an assigned video at my university ahahah - what's odd to me is that the capability to adjust the volume is already there. There is clearly a video.setVolume(0 to 100) when I stepped through with the developer tools, but it's just inaccessible.

Technically I can just adjust the volume of my computer but that just seems cumbersome for a feature that is already theoretically available. Have the maintainers taken a look at this?

fudgepop01 avatar Sep 30 '24 15:09 fudgepop01