h5p-image-hotspots icon indicating copy to clipboard operation
h5p-image-hotspots copied to clipboard

Published 20 hours ago • verified publisher icon h5p

Feature Request: Allow more customization to hotspots (Already Completed)

Open lukemuller opened this issue 8 years ago • 4 comments

Hi Guys,

I've already completed this feature request for my company and thought it'd be useful to share with the community.

User story:

As an author I want to be able to customize the icons used for the hotspots including the background color and color of the icon to suit varying background images.

I also want to be able to use letters or numbers (max 2 chars) to display on the hotspot if needed for example 10 or AB.

UX: Have a group that is default to collapsed containing all the options to avoid taking up too much room if the author just wants to use the default options. Icons can be changed from an icon selector similar to the color selector.

Accessibility: Will be improved as the color of the hotspots can now be suited based on the background image.

Technical solution: I created a new editor similar to the color selector (this can now be used in any other h5p content aswell) using https://codeb.it/fonticonpicker/. It is basically a text field that contains the fa-*** code from font awesome so can be applied to a css class to display the icon.

The icon-selector editor can be found here: https://github.com/lukemuller/h5p-editor-icon-selector

And the update to the h5p-image-hotspots content type here: https://github.com/lukemuller/h5p-image-hotspots-icon-customisation

Thanks!

lukemuller avatar Mar 23 '17 23:03 lukemuller

Sounds really good! Do you want us to consider to merge in the changes (and make your code part of the official MIT licensed Image Hotspots)?

Where are your modifications? They are probably there, I'm not that used to GitHub, but I can't find them :)

https://github.com/lukemuller/h5p-image-hotspots-icon-customisation/commits/master

falcon-git avatar Mar 24 '17 13:03 falcon-git

@falcon-git Certainly, that would be great!

Whoops, looks like I forgot to push my changes. I've pushed the changes to that branch and they should be viewable now. I've also opened a pull request.

lukemuller avatar Mar 26 '17 21:03 lukemuller

:)

falcon-git avatar Mar 27 '17 07:03 falcon-git

I have had a quick look and it looks solid. Someone else from the Core Team will go through it in greater detail and hopefully merge it in for the Fulla release. (Not the one being worked on now, but the next)

Made this Jira issue for it. Thanks a lot for contributing!

falcon-git avatar Mar 27 '17 08:03 falcon-git