h5p-editor-php-library icon indicating copy to clipboard operation
h5p-editor-php-library copied to clipboard

Double slash in ckeditor basePath

Open yannick-t opened this issue 6 years ago • 1 comments

Hi, In h5p-editor-html.js the basePath for ckeditor is set to CKEDITOR.basePath = ns.basePath + '/ckeditor/' which results in a double slash because basePath already has a trailing slash. (at least in the wordpress implementation and from what I've tested it is needed for the darkroom image editor because there the path is set without an extra slash).

From what I've gathered this results in a valid url and for example in wordpress it is interpreted correctly but it does not seem to be intended. I'm currently experimenting with a Java backend for h5p and jetty is not happy with the double slash

yannick-t avatar Jul 23 '18 11:07 yannick-t

I have transformed this into a JIRA issue where you can follow along the progress: https://h5ptechnology.atlassian.net/browse/HFP-2146

thomasmars avatar Aug 06 '18 14:08 thomasmars