Add directionality (bidi) support to all wysiwygs

[nadavkav]

Suggested fix depends on regenerating (or adding) ckeditor with bidi plugin support.

[timothyylim]

Great work @nadavkav , I've made an issue for this pull request to be reviewed and merged in. You can follow it's progress here:

https://h5ptechnology.atlassian.net/browse/HFP-781

The Core Team has just started work on the H5P Hub so it might take a while but I hope we can get it done soon!

[fnoks]

Hi @nadavkav,

Could you regenerate ckeditor with bidi plugin support, and make it part of this pull request? There is a build-config.js you can use when doing this!

[nadavkav]

Hi @fnoks , I see the issue is already closed on your jira. did you generated the required ckeditor with bidi plugin support, or should I?

[fnoks]

Hi,

If you generate the ckeditor, I will reopen the Jira issue :)

[nadavkav]

I think it is better you generate it, as I am not sure what is the basic setup of other plugins you are expecting to include with your core version.

[icc]

Just a small note: Bidi has been added to the CKEditor, the PR is about if we should enable the buttons by default for everyone.

[nadavkav]

@icc , this is a very old PR, as we are using a newer version with a global setting that allow the admin to enable/disable the display of RTL/LTR buttons in the CKEditor toolbar.

Better use the following code, and not this PR https://github.com/iucc/h5p-moodle-plugin/blob/v1191_rtl_support/editor/scripts/h5peditor-html.js#L74-L80 https://github.com/iucc/h5p-moodle-plugin/blob/v1191_rtl_support/locallib.php#L214 https://github.com/iucc/h5p-moodle-plugin/blob/v1191_rtl_support/settings.php#L120

[icc]

@nadavkav Thank you.