h5p-editor-php-library icon indicating copy to clipboard operation
h5p-editor-php-library copied to clipboard

Override the configuration to allow extraContent

Open 4pr3x opened this issue 9 years ago • 5 comments

Hi,

we´re using the h5p-editor-php-library & h5p-php-library on a not official supported platform. (https://www.efrontlearning.com/blog/2016/04/h5p-integration-efrontpro-4-4.html)

I´m trying since several days to allow more html tag´s in the editor, but any tries doesn´t seem to have an effect. I followed this http://docs.ckeditor.com/#!/guide/dev_acf documention. Additional I´ve built a custom ckEditor in with the ckEditor-builder and I also changed the proper TAGs in the semantics.json of the plugin we´re using H5P.TEXT-1.1. But nothing worked so far.

Path of the config File i worked with: /h5p-resource/h5p-editor-php-library/ckeditor/config.js I tried to disable ACF CKEDITOR.config.allowedContent = true; I also tried to allowExtraContent config.extraAllowedContent = 'dl dt dd button'; and several other things.

Does anyone have an idea what I´m doing wrong or what I probably missed here?

4pr3x avatar Nov 09 '16 08:11 4pr3x

Very hard to say. Adding them to semantics should normally do the trick. In the official implementations the semantics is stored in the database so changing it on the file system wouldn't change anything. Could that be the problem? (Probably not, but lets get that option off the table)

falcon-git avatar Nov 09 '16 08:11 falcon-git

Thanks for the quick reply.

I´ll check the database as soon as possible. But I thought, by installing a new plugin via the provided UI of our system, it would read the created .h5p file and does the changes itself. But we will see.

Another idea was that our system does some kind of sanitize submitted data on a higher abstraction level then ACF is.

EDIT: I checked the database. I guess was right, the semantics field was updated by using the provided UI. I´m now waiting for a response of the support of our system, probably the issue is based on how the system does sanitize submitted data.

4pr3x avatar Nov 09 '16 08:11 4pr3x

You have any idea for which reason I cannot even add plugins for the ckEditor itself? I completely rebuild it with the CKBuilder, I added several plugins (including the sourcedialog). Then I replaced the files provided by the Platform, but nothing changed.

Isn´t that the way to bring new functionality to the editor? Or do I have to do it like here? https://h5p.org/adding-text-editor-buttons

Does H5P Plugin somewhere define, how much functionality it needs from the ckEditor or how is this working? Because for some plugins there are more buttons in the toolbar then for others .

4pr3x avatar Nov 10 '16 07:11 4pr3x

You shoud do it like on https://h5p.org/adding-text-editor-buttons

Code related to configuring ckeditor is in https://github.com/h5p/h5p-editor-php-library/blob/master/scripts/h5peditor-html.js

Kind regards,

Svein-Tore Griff With

for Joubel

h5p/h5p-editor-php-library on November 10, 2016 at 8:30am wrote:

You have any idea for which reason I cannot even add plugins for the ckEditor itself? I completely rebuild it with the CKBuilder, I added several plugins (including the sourcedialog). Then I replaced the files provided by the Platform, but nothing changed.

Isn´t that the way to bring new functionality to the editor? Or do I have to do it like here? https://h5p.org/adding-text-editor-buttons

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub ( https://github.com/h5p/h5p-editor-php-library/issues/19#issuecomment-259620269 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/ATkhbGo0aayNhx4-OMU5o75YB6cVe-nzks5q8sgGgaJpZM4KtR_p ) .

h5p/h5p-editor-php-library on November 9, 2016 at 9:45am wrote:

Thanks for the quick reply.

I´ll check the database as soon as possible. But I thought, by installing a new plugin via the provided UI of our system, it would read the created .h5p file and does the changes itself. But we will see.

Another idea was that our system does some kind of sanitize submitted data on a higher abstraction level then ACF is.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub ( https://github.com/h5p/h5p-editor-php-library/issues/19#issuecomment-259360990 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/ATkhbHXk9JQ1Ndahk0_unIlSd5I22rhvks5q8YgUgaJpZM4KtR_p ) .

h5p/h5p-editor-php-library on November 9, 2016 at 9:36am wrote:

Very hard to say. Adding them to semantics should normally do the trick. In the official implementations the semantics is stored in the database so changing it on the file system wouldn't change anything. Could that be the problem? (Probably not, but lets get that option off the table)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub ( https://github.com/h5p/h5p-editor-php-library/issues/19#issuecomment-259359494 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/ATkhbOtbYtdRux9xtZhvN9OW1Pugn0ARks5q8YYOgaJpZM4KtR_p ) .

h5p/h5p-editor-php-library on November 9, 2016 at 9:26am wrote:

Hi,

we´re using the h5p-editor-php-library & h5p-php-library on a not official supported platform. (https://www.efrontlearning.com/blog/2016/04/h5p-integration-efrontpro-4-4.html)

I´m trying since several days to allow more html tag´s in the editor, but any tries doesn´t seem to have an effect. I followed this http://docs.ckeditor.com/#!/guide/dev_acf documention.

Additional I´ve built a custom ckEditor in with the ckEditor-builder and I also changed the proper TAGs in the semantics.json of the plugin we´re using H5P.TEXT-1.1. But nothing worked so far.

Path of the config File i worked with: /h5p-resource/h5p-editor-php-library/ckeditor/config.js

I tried to disable ACF CKEDITOR.config.allowedContent = true;

I also tried to allowExtraContent config.extraAllowedContent = 'dl dt dd button';

and several other things.

Does anyone have an idea what I´m doing wrong or what I probably missed here?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub ( https://github.com/h5p/h5p-editor-php-library/issues/19 ), or mute the thread ( https://github.com/notifications/unsubscribe-auth/ATkhbFpPHLL851rLClsLyrpaViOkP6Owks5q8YOegaJpZM4KtR_p ) .

H5P-Helper avatar Nov 10 '16 08:11 H5P-Helper

You shoud do it like on https://h5p.org/adding-text-editor-buttons

Code related to configuring ckeditor is in https://github.com/h5p/h5p-editor-php-library/blob/master/scripts/h5peditor-html.js

:)

Kind regards,

Svein-Tore Griff With

for Joubel

h5p/h5p-editor-php-library on November 10, 2016 at 9:42am wrote:

Thanks for the reply. If I do changes in the h5peditor-html.js I can see changes, which is much more than I achieved over the last two days.

Is there any documention on how to push sourcecode mode in the editor?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub ( https://github.com/h5p/h5p-editor-php-library/issues/19#issuecomment-259632546 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/ATkhbG3PHdkb9lhABQ-mwEw3M7-KfolNks5q8tj5gaJpZM4KtR_p ) .

Svein-Tore Griff With on November 10, 2016 at 9:12am wrote:

You shoud do it like on https://h5p.org/adding-text-editor-buttons

Code related to configuring ckeditor is in https://github.com/h5p/h5p-editor-php-library/blob/master/scripts/h5peditor-html.js

h5p/h5p-editor-php-library on November 10, 2016 at 8:30am wrote:

You have any idea for which reason I cannot even add plugins for the ckEditor itself? I completely rebuild it with the CKBuilder, I added several plugins (including the sourcedialog). Then I replaced the files provided by the Platform, but nothing changed.

Isn´t that the way to bring new functionality to the editor? Or do I have to do it like here? https://h5p.org/adding-text-editor-buttons

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub ( https://github.com/h5p/h5p-editor-php-library/issues/19#issuecomment-259620269 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/ATkhbGo0aayNhx4-OMU5o75YB6cVe-nzks5q8sgGgaJpZM4KtR_p ) .

h5p/h5p-editor-php-library on November 9, 2016 at 9:45am wrote:

Thanks for the quick reply.

I´ll check the database as soon as possible. But I thought, by installing a new plugin via the provided UI of our system, it would read the created .h5p file and does the changes itself. But we will see.

Another idea was that our system does some kind of sanitize submitted data on a higher abstraction level then ACF is.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub ( https://github.com/h5p/h5p-editor-php-library/issues/19#issuecomment-259360990 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/ATkhbHXk9JQ1Ndahk0_unIlSd5I22rhvks5q8YgUgaJpZM4KtR_p ) .

h5p/h5p-editor-php-library on November 9, 2016 at 9:36am wrote:

Very hard to say. Adding them to semantics should normally do the trick. In the official implementations the semantics is stored in the database so changing it on the file system wouldn't change anything. Could that be the problem? (Probably not, but lets get that option off the table)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub ( https://github.com/h5p/h5p-editor-php-library/issues/19#issuecomment-259359494 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/ATkhbOtbYtdRux9xtZhvN9OW1Pugn0ARks5q8YYOgaJpZM4KtR_p ) .

h5p/h5p-editor-php-library on November 9, 2016 at 9:26am wrote:

Hi,

we´re using the h5p-editor-php-library & h5p-php-library on a not official supported platform. (https://www.efrontlearning.com/blog/2016/04/h5p-integration-efrontpro-4-4.html)

I´m trying since several days to allow more html tag´s in the editor, but any tries doesn´t seem to have an effect. I followed this http://docs.ckeditor.com/#!/guide/dev_acf documention.

Additional I´ve built a custom ckEditor in with the ckEditor-builder and I also changed the proper TAGs in the semantics.json of the plugin we´re using H5P.TEXT-1.1. But nothing worked so far.

Path of the config File i worked with: /h5p-resource/h5p-editor-php-library/ckeditor/config.js

I tried to disable ACF CKEDITOR.config.allowedContent = true;

I also tried to allowExtraContent config.extraAllowedContent = 'dl dt dd button';

and several other things.

Does anyone have an idea what I´m doing wrong or what I probably missed here?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub ( https://github.com/h5p/h5p-editor-php-library/issues/19 ), or mute the thread ( https://github.com/notifications/unsubscribe-auth/ATkhbFpPHLL851rLClsLyrpaViOkP6Owks5q8YOegaJpZM4KtR_p ) .

H5P-Helper avatar Nov 10 '16 11:11 H5P-Helper