ABS icon indicating copy to clipboard operation
ABS copied to clipboard

Rewards link changed

Open wearysky opened this issue 2 years ago • 14 comments

Too lazy to branch and commit separately, but just an FYI @h4x0rm1k3 it looks like Microsoft has fully committed to redirecting all rewards.microsoft.com browsing sessions to rewards.bing.com some time this week. Might not be rolled out to everyone, but it's definitely happening for me now. I had to update all references to the old URL to point to the new one, otherwise it wasn't auto-clicking the links anymore.

wearysky avatar Dec 01 '22 14:12 wearysky

For those who want to manually fix this on their own until a commit goes in - it's manifest.json and constants.js that need editing.

wearysky avatar Dec 02 '22 14:12 wearysky

For those who want to manually fix this on their own until a commit goes in - it's manifest.json and constants.js that need editing.

For the edits, do you mean simply change all instances of rewards.microsoft.com to rewards.bing.com?

My searches are working fine, it's just the Rewards Tasks. Broke my 160 day streak!

ChippewaBarr avatar Dec 02 '22 15:12 ChippewaBarr

@wearysky , I literally checked back on here 2 days ago to see if any issues and there was none outstanding so I literally missed you by a day! I only noticed today that my rewards hadn't done so glad you'd already picked up on it and worked out what was going on. I'm going to implement the fixes now and upload them. Thanks for finding and bringing awareness.

h4x0rm1k3 avatar Dec 02 '22 16:12 h4x0rm1k3

@wearysky , I literally checked back on here 2 days ago to see if any issues and there was none outstanding so I literally missed you by a day! I only noticed today that my rewards hadn't done so glad you'd already picked up on it and worked out what was going on. I'm going to implement the fixes now and upload them. Thanks for finding and bringing awareness.

All good! The funny thing is, I did a Windows reinstall the day that it switched over, so I thought I had messed something up in my reinstall, somehow, and could NOT figure it out. It was only when I decided to take a closer look at the extension that I realized the problem.

Also: I started the v3 manifest conversion. The final issue I have to fix is that it keeps throwing inline code CSP errors for the element.click events, and there appears to be workarounds for that but I don't quite have my head wrapped around them yet.

wearysky avatar Dec 02 '22 17:12 wearysky

I might have done something wrong but I noticed my rewards stopped doing the normal thing. Installed the new version from the latest commits. Anything else I need to do? It's still not working on opening up the links automatically from the rewards page.

Filaipus avatar Dec 04 '22 23:12 Filaipus

I might have done something wrong but I noticed my rewards stopped doing the normal thing. Installed the new version from the latest commits. Anything else I need to do? It's still not working on opening up the links automatically from the rewards page.

Are you waiting a bit for the tasks to start?

I believe @h4x0rm1k3 implemented a 3 minute lag between the searches happening and the tasks starting. If I recall it was done since sometimes the tasks wouldn't complete it the searches were still taking place. Please someone correct me if I'm wrong.

ChippewaBarr avatar Dec 04 '22 23:12 ChippewaBarr

I might have done something wrong but I noticed my rewards stopped doing the normal thing. Installed the new version from the latest commits. Anything else I need to do? It's still not working on opening up the links automatically from the rewards page.

Are you waiting a bit for the tasks to start?

I believe @h4x0rm1k3 implemented a 3 minute lag between the searches happening and the tasks starting. If I recall it was done since sometimes the tasks wouldn't complete it the searches were still taking place. Please someone correct me if I'm wrong.

I was trying to trigger them manually by pressing the "open rewards" button. Would i still need to wait in that use case?

Filaipus avatar Dec 05 '22 00:12 Filaipus

I might have done something wrong but I noticed my rewards stopped doing the normal thing. Installed the new version from the latest commits. Anything else I need to do? It's still not working on opening up the links automatically from the rewards page.

Are you waiting a bit for the tasks to start? I believe @h4x0rm1k3 implemented a 3 minute lag between the searches happening and the tasks starting. If I recall it was done since sometimes the tasks wouldn't complete it the searches were still taking place. Please someone correct me if I'm wrong.

I was trying to trigger them manually by pressing the "open rewards" button. Would i still need to wait in that use case?

Yes I believe so.

If I manually click that button nothing will happen for like 3 minutes then they will all open.

ChippewaBarr avatar Dec 05 '22 00:12 ChippewaBarr

@Filaipus Yes you still have to wait, the only way to overide them is to open them each individually, I implemented a 3 minute delay a while back as the searches were interfering when rewards were going on.

h4x0rm1k3 avatar Dec 05 '22 00:12 h4x0rm1k3

Thanks for the update, brother!

daedalus311 avatar Dec 05 '22 13:12 daedalus311

Ok I waited the 3 minutes and it finally worked. I'm sorry for the impatience haha Thanks for the great work, appreciate it!

Filaipus avatar Dec 05 '22 15:12 Filaipus

All good! The funny thing is, I did a Windows reinstall the day that it switched over, so I thought I had messed something up in my reinstall, somehow, and could NOT figure it out. It was only when I decided to take a closer look at the extension that I realized the problem.

Also: I started the v3 manifest conversion. The final issue I have to fix is that it keeps throwing inline code CSP errors for the element.click events, and there appears to be workarounds for that but I don't quite have my head wrapped around them yet.

@wearysky I just noticed the comment about manifest V3 and you're having some issues with CSP errors, any chance you mind sharing the code you've got so far and i'll take a look and see if I can puzzle out how to get it running, two heads and all that! I'm guessing it's only the rewards tasks/clicking that are the issue now or is search still an issue too in manifest v3? If you want to send it me directly you can email me at my username @gmail.com . Thanks

h4x0rm1k3 avatar Dec 06 '22 01:12 h4x0rm1k3

@h4x0rm1k3 sent!

wearysky avatar Dec 07 '22 13:12 wearysky

I updated the firefox add-on in the developer portal and it still doesn't seem to be opening for some reason. Have uninstalled and reinstalled a couple times now, but still not opening up after the initial searches complete (after 3 minutes).

DrDagless avatar Dec 08 '22 03:12 DrDagless