tyra icon indicating copy to clipboard operation
tyra copied to clipboard

Check for possible "const &" and "inline" improvements.

Open h4570 opened this issue 3 years ago • 0 comments

I'm sure that many of getters/setters can have better performance by simply add inline keyword. Also many of functions (math.cpp, vifsender.cpp, ...) do not have const & parameters where it should be.

Examples of lack of inline: https://github.com/h4570/tyra/blob/3e385f7c8474cf66ff88e8132f22094caace89f5/src/engine/include/models/mesh_frame.hpp#L37 https://github.com/h4570/tyra/blob/3e385f7c8474cf66ff88e8132f22094caace89f5/src/engine/include/models/mesh_frame.hpp#L82

Examples of lack of const &: https://github.com/h4570/tyra/blob/3e385f7c8474cf66ff88e8132f22094caace89f5/src/engine/include/models/math/vector3.hpp#L34

h4570 avatar Dec 04 '20 14:12 h4570