dolly
dolly copied to clipboard
Use mint types in public API
Implements https://github.com/h3r2tic/dolly/issues/16. It still leaves the conversion between types looking a bit messy in the examples. Happy to discuss and see if we can rework this. I think it would be neater if macroquad exposed a similar mint
feature.
Apologies for the delay, had some busy times lately 😅
This looks great! Thank you for the hard work 💗 I've just tested your branch in Tiny Glade, and it only took a few changes in our 400loc camera module. All pretty much a handful of .into()
s and temporary bindings for where we were previously using &mut
to mutate some internal driver vectors.
Not too annoying overall, and it could be a win for folks trying to use other math libs.
I'm not sure whether this will actually help with the glam
semver bounds -- in Tiny Glade we're actively combing our crates, and duplicates are denied via cargo-deny
except where our hands are tied. For the sake of reducing crate duplicates, we'll probably still need to bump dolly
for new versions of glam
, but using mint
should allow users to be lazier with their dependency combing, as they will be able to upgrade their glam
separately, and not have to change all the code around dolly
.
So considering all this, it's still probably a good idea to merge this PR -- and if it backfires, we'll re-evaluate 🙂
I've cleaned up a Clippy warning, and also changed a few mint::Vector3
to be mint::Point3
, as that might be relevant to math libs which have separate types for points and vectors.
Any updates on this one? :)
@h3r2tic I'm cleaning up my account and would like to delete my fork. Do you plan to merge these changes?
I think I was initially waiting to see if you'd have any comments on my changes, but I guess I didn't indicate that :P Then it slipped under my radar - sorry about that. Will allocate some time this week to finalize this! 💚
This is now released in 0.5.0
🚀 I've also done a pass to check the examples in the README, and add tests for them.
Thanks for your contribution, and once again apologies for the delay 🖖