esp-nimble-cpp icon indicating copy to clipboard operation
esp-nimble-cpp copied to clipboard

question - update from 1.2 to 1.3.3

Open mitchjs opened this issue 2 years ago • 3 comments

Hi there, been a while for me, but i needed to make an update to my existing project so i figured id update the Nimble-CPP component i had to make 1 change to my code

// create main service
pService = pServer->createService(NimBLEUUID(SERVICE_UUID), 75);
to
// create main service
pService = pServer->createService(NimBLEUUID(SERVICE_UUID));

im just wondering is this automatic now to allocate the "space" for all the characteristics?

thanks again for great work on this mitch

mitchjs avatar Jun 30 '22 16:06 mitchjs

oh i saw on some githubs, a discussion section you can add, for talking about things like this

mitch

mitchjs avatar Jun 30 '22 16:06 mitchjs

Hi @mitchjs, been a while for sure 😄. That parameter was never used by this library so I just removed it. Minor API breakage I figured.

h2zero avatar Jun 30 '22 17:06 h2zero

i thought it was, if the value was too small, characteristics wouldnt get made, it was for some memory allocation (i cant test my new code, yet... i updated whole project to the ESP32-S3 and waiting on dev board to test out) been a while since i needed to look at code, so what do i know :)

mitchjs avatar Jun 30 '22 17:06 mitchjs