NimBLE-Arduino icon indicating copy to clipboard operation
NimBLE-Arduino copied to clipboard

LOG_LEVEL defines collision

Open vovagorodok opened this issue 2 years ago • 3 comments
trafficstars

At log_common.h we have defined:

#define LOG_LEVEL_DEBUG    (0)
#define LOG_LEVEL_INFO     (1)
#define LOG_LEVEL_WARN     (2)
#define LOG_LEVEL_ERROR    (3)
#define LOG_LEVEL_CRITICAL (4)
#define LOG_LEVEL_NONE     (5)

LOG_LEVEL.. names are very common and I have redefinition issues when another than NibBle logger is used.
Because its internal NibBle logger, proposed to use some internal names like: BLE_LOG_LEVEL.. or NIM_BLE_LOG_LEVEL..

vovagorodok avatar Nov 26 '22 21:11 vovagorodok

This file is maintained upstream, this issue would be better to bring up there.

h2zero avatar Nov 30 '22 03:11 h2zero

Created. Lets wait the answer: https://github.com/espressif/esp-nimble/issues/49

vovagorodok avatar Nov 30 '22 15:11 vovagorodok

This will be resolved when updated by espressif.

h2zero avatar Jun 04 '24 21:06 h2zero