angular-material-components icon indicating copy to clipboard operation
angular-material-components copied to clipboard

Hours input changes 12 to 00 even when enableMeridian is true

Open Doc1027 opened this issue 4 years ago • 13 comments

Is there a way to force the hours input to a 12 hour clock? If one were to set the value to 12, it automatically changes to 00 when it loses focus even when enableMeridian is set to true. This behavior is present in your StackBlitz. Also, if I'm using this control to edit a datetime value say "8/4/2020 12:00 pm" the time portion of the control defaults to 12:00 AM

Doc1027 avatar Aug 04 '20 13:08 Doc1027

Created pull request #131, now waiting for merge.

When enableMeridian is true then it should now correctly change 00 to 12, when changing date the time portion won't change and also the input value will be shown and interpreted correctly.

cklam2 avatar Oct 09 '20 15:10 cklam2

Running into this issue as well. Would love to see this PR get merged.

vyrotek avatar Nov 03 '20 23:11 vyrotek

Please merge this to make my life just 1% easier

MarcBate avatar Nov 13 '20 17:11 MarcBate

@MarcBate Sorry for my late reply. I will check it out and try to merge this.

h2qutc avatar Nov 13 '20 17:11 h2qutc

@MarcBate Sorry for my late reply. I will check it out and try to merge this.

Do you think you can get to this today? We are rolling out a version and would love to get this fix in there. When a user types 12 for the hour it changes to 00.

MarcBate avatar Nov 16 '20 15:11 MarcBate

@h2qutc Can you merge this and the other important PRs that were submitted? If maintaining the project is too time-consuming, maybe it's a good idea to add an extra maintainer to help you out.

coyoteecd avatar Nov 19 '20 12:11 coyoteecd

@h2qutc Could you please merge this?

vyrotek avatar Dec 11 '20 21:12 vyrotek

@h2qutc Can you please merge this?

MihirSomani avatar Jan 17 '21 01:01 MihirSomani

@h2qutc can we know when the pr might be merged?

Naveen-ux avatar May 12 '21 11:05 Naveen-ux

@h2qutc Can you please merge this PR

pandiyaavps avatar May 12 '21 12:05 pandiyaavps

@h2qutc can you merge this one too? Or assign a maintainer to do it...

coyoteecd avatar Jun 14 '21 12:06 coyoteecd

@coyoteecd Hi, the new version (5.1.1 for Angular 11, 6.0.3 for Angular 12) with the correction of this bug has already been released. Feel free to check it out and let me know if it works.

h2qutc avatar Jun 14 '21 12:06 h2qutc

6.0.3 fixed the issue when typing 12 would change to 0, but when selecting 12:45 am for example the text displayed shows 24:45, which isn't a time image

MarcBate avatar Jun 16 '21 16:06 MarcBate