angular-material-components icon indicating copy to clipboard operation
angular-material-components copied to clipboard

Published 20 hours ago • verified publisher icon h2qutc

Timepicker disabling/enabling not working with dynamic forms

Open vincentdieltiens opened this issue 3 years ago • 0 comments

With dynamic forms, Angular encourages to not use the [disabled] attribute but the disable() and enable() methods (or set it at control creation).

The timepicker component set a _disabled property that is not used :

https://github.com/h2qutc/angular-material-components/blob/f147c1c9645167fb170bbca4aa9d91f757c2bb5a/projects/datetime-picker/src/lib/timepicker.component.ts#L135-L138

the method setDisabledState should disable/enable the inputs and set the disabledproperty (not _disabled)

vincentdieltiens avatar Nov 17 '21 21:11 vincentdieltiens