wave icon indicating copy to clipboard operation
wave copied to clipboard

Add enter handler for the textbox

Open VijithaEkanayake-zz opened this issue 4 years ago • 2 comments

Fixes: https://github.com/h2oai/wave/issues/372

VijithaEkanayake-zz avatar Dec 18 '20 05:12 VijithaEkanayake-zz

@mturoci - this might conflict with #348?

Yes, I suppose. I suggest addressing both issues in this PR.

mturoci avatar Dec 18 '20 09:12 mturoci

The implementation unconditionally calls the keyup handler. We need a properly-named attribute on the textbox that conditionally enables this behavior.

@mturoci - this might conflict with #348?

@lo5 @mturoci Introduced a new attribute called submit to the textbox to conditionally call the keyUp handler and addressed the requested changes.

VijithaEkanayake-zz avatar Dec 18 '20 14:12 VijithaEkanayake-zz