wave icon indicating copy to clipboard operation
wave copied to clipboard

Give all widgets the name parameter

Open mtanco opened this issue 1 year ago • 4 comments

Is your feature request related to a problem? Please describe

It is very common to update parameters of components throughout the app usage lifecycle. This is most easily done with the name parameter, but not every component has that parameter. This means new-er users to the framework will learn about updating with the name component: q.page["test"].my_component.content = "hey" but then have no idea what to do when name is not there.

They can ("of course") use the old index method: q.page["test"].items[2].textbox.value="hey" but this is harder and often Wave users that joined after the 1.0.0 release will not know about this.

Describe the solution you'd like

  • [ ] An audit of all components to make a list of everything that does not have name as a parameter
  • [ ] Add name as a parameter to all of these

Describe alternatives you've considered

  • Leave things as is, monitor chats and teach people about the old method
  • Write new docs with key words that people might find when they try to update things like image

Additional context

Resolved question: https://github.com/h2oai/wave/discussions/2338

mtanco avatar Jun 11 '24 14:06 mtanco

Hi - could I grab this issue, please?

Will-Marriott avatar Jun 14 '24 15:06 Will-Marriott

hey i want to fix this issue

anirudhmehra12 avatar Aug 03 '24 15:08 anirudhmehra12

hey can you assign this issue to me

akhilk2802 avatar Sep 01 '24 19:09 akhilk2802

.take

BatatiDE avatar Nov 19 '24 20:11 BatatiDE