wave-apps
wave-apps copied to clipboard
h2oai
Test that READ ME setup works on all OS
Following the read me, check that apps run on OS X, Windows, and Linux - make any setup change as needed and note what versions of these were tested
Hi i came to know about h2oai through hacktoberfest and would like to contribute
I have windows and i can try to arrange mac os and ubuntu from my friends
Since @ayushtiwari110 was here first, will assign this issue to him. If 4 days pass without a PR, the issue will become up for grabs again.
@topguns837 feel free to pick some other issue in the meanwhile :)
Hello, Till now I have tested the installation of wave server in windows and linux and it was buttery smooth. Coming to Explainable hotel ratings app, I have tested installing it on windows and is having some issues. I am still rectifying whether these issues are in the code or in my PC. I wanted to ask that for this issue, do I just have to update the ReadMe with possible info or do I have to make change to code if it doesn't install?? Thanks for your time and consideration :)
Hi,
I am currently working on Windows. Please let me know how to go forward with this.
Poorva
On Mon, Oct 3, 2022, 12:17 AM mturoci @.***> wrote:
Hi @poorvabedmutha31 https://urldefense.com/v3/__https://github.com/poorvabedmutha31__;!!Mih3wA!C9Q2Xg_HtKP14H4STRxAVDID1rgvre7OmGHX8cqMSciOK3vMuKAPEQ3PyiqGfnlLqX569S4QRlSsyaEO9rO_xkLVIA$ @AshwinSatyawan https://urldefense.com/v3/__https://github.com/AshwinSatyawan__;!!Mih3wA!C9Q2Xg_HtKP14H4STRxAVDID1rgvre7OmGHX8cqMSciOK3vMuKAPEQ3PyiqGfnlLqX569S4QRlSsyaEO9rNwl0Ms3Q$. What OS do you both have?
— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/h2oai/wave-apps/issues/22*issuecomment-1265033479__;Iw!!Mih3wA!C9Q2Xg_HtKP14H4STRxAVDID1rgvre7OmGHX8cqMSciOK3vMuKAPEQ3PyiqGfnlLqX569S4QRlSsyaEO9rNniXSagg$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ANNRORJF4CBWWE7YTADZHKLWBKCCHANCNFSM4UXFZPGA__;!!Mih3wA!C9Q2Xg_HtKP14H4STRxAVDID1rgvre7OmGHX8cqMSciOK3vMuKAPEQ3PyiqGfnlLqX569S4QRlSsyaEO9rPaCqSzHA$ . You are receiving this because you were mentioned.Message ID: @.***>
I wanted to ask that for this issue, do I just have to update the ReadMe with possible info or do I have to make change to code if it doesn't install??
@ayushtiwari110 the goal of this issue is to make sure all the apps are runnable irrespective of OS. I would expect that only setup instructions would need the update - so that they are applicable for everyone. The app code should be already platform-agnostic (although this may not be 100% true)
@poorvabedmutha31 This issue is currently taken, please pick some other issue this time. Thanks!
@mturoci Thanks for confirming the same. Now my full focus will be on updating the setup instructions
Hello, I have tested installation of all apps in Max OS Monterey: Guess the Number, Shopping Cart, Social Media Sentiments , these three apps work fine without any issues or anything complex :) The rest of the apps show an error "pip subprocess to install build dependencies did not run successfully", along with some long output Looking a bit on output I guess it has something to do with numpy library, subprocess error start there. I will see if I can find source of error. Do let me know any info you wish to tell :) I will be seeing if I can add anything in Mac OS installation part of ReadMe. Further I will test on windows and linux and will let you know.
update: Today I tested it on windows. The situation is almost similar to mac, same apps working and others having same issue. One difference is that for making it work in windows, I had to make a change in the makefile of each app. I had to change the word "bin" to "Scripts" in the path of venv in make setup and make run commands.
I guess so far I can update this Scripts thing in the readme, and further I can try to simplify some instructions if I feel they need to be. I had a doubt, Should I do any other changes or try to identify the subprocess error as a part of this issue?
P.S. I will probably try to test it on linux tomorrow.
I suppose make only works on Windows when using WSL? If so, it would be good to unify the instructions so that they work in both unix/windows-based terminals.
I guess so far I can update this Scripts thing in the readme, and further I can try to simplify some instructions if I feel they need to be.
Yes, sounds good.
Should I do any other changes or try to identify the subprocess error as a part of this issue?
We can leave it as a separate issue.
hello @mturoci , I tested the installation on windows and mac. I was not able to arrange Linux, so didn't test apps on it. Although one of my friends conveyed that wave server installation is fine on Linux too. The versions tested are the latest versions of each app. As discussed I have created a PR for the 'Scripts' issue and a few issues whose fixes were known to me. I had a look at the Readme of individual apps also, and I feel that they are fine and don't require any changes. As these issues are in general to any app, I have updated them in the Readme of the main branch. Kindly have a look at the PR
Hey, Kindly check the PR, and if you feel everything is good, kindly accept it and mark as hactoberfest accepted
Hey @mturoci kindly check that pr , and if its good plz mark as hacktoberfest accepted
Reviewed it a couple days back, but forgot to hit the submit review button. Sorry about that.
Looks like this is also related to https://github.com/h2oai/wave-apps/pull/123 and a stale issue? perhaps one can updated the status of this issue to reflect the correct state so volunteers like myself can focus on more pressing issues?
