mli-resources icon indicating copy to clipboard operation
mli-resources copied to clipboard

Examples via Docker: missing mli-resources clone & jupyter to be run w/ --allow-root

Open dvorka opened this issue 5 years ago • 5 comments

In order to successfully install examples using Docker I did the following changes:

  • There seems to be missing step which clones mli-resources GitHub repository. Perhaps RUN git clone https://github.com/h2oai/mli-resources.git should be added to Dockerfile (I cloned repo manually).
  • Jupyter refuses to start under root - consider adding --allow-root parameter: docker run -i -t -p 8888:8888 <image_id> /bin/bash -c "/opt/conda/bin/conda install jupyter -y --quiet && /opt/conda/bin/jupyter notebook --notebook-dir=/mli-resources --ip='*' --port=8888 --no-browser --allow-root" and/or suggest to run it under a normal user.
  • Perhaps it would be worth to suggest user to use URL provided by Jupyter after it starts - it contains auth token (README.md, step 9.).

dvorka avatar Sep 21 '18 16:09 dvorka

DOH - this is a regression ... ok we will update. Thanks for making us aware.

jphall663 avatar Sep 21 '18 16:09 jphall663

@dvorka sorry this is all related to a very rushed, half-assed upgrade to py 3.6 by yours truly. I'm going through the notebooks 1-by-1 one right now. Give me a few hours ... :face_palm:

jphall663 avatar Sep 21 '18 18:09 jphall663

I'm at "works for me" - so I dare not close this yet. This was a mess ... I wasn't expecting it to be this difficult to go from py35 to py36 (I do this to use the shap package).

jphall663 avatar Sep 22 '18 01:09 jphall663

@navdeep-G IF you have time - or we get more complaints - can you remove your old docker image, rebuild from the new dockerfile, and run all the notebooks, including the ones for comparing explanations ... it takes forever. sorry. If you get no errors we can probably close.

jphall663 avatar Sep 22 '18 01:09 jphall663

@jphall663 No problem. I really appreciate your prompt response and effort!

dvorka avatar Sep 22 '18 10:09 dvorka