h2o-3 icon indicating copy to clipboard operation
h2o-3 copied to clipboard

PUBDEV-8768 - fix testUniqueRowsWithCounts

Open valenad1 opened this issue 2 years ago • 3 comments

Original test throws away the last row because of wrongly defined chunk layout. This commit fix it and enhance the test.

I didn't touch input, only add correct reference and enhance asserting.

valenad1 avatar Aug 01 '22 16:08 valenad1

@valenad1 this would mean that the issue really only affects small datasets and in reasonably large datasets the values are accurate for all practical purposes, correct?

michalkurka avatar Aug 01 '22 20:08 michalkurka

or is this just about making the test fail and no fix yet?

michalkurka avatar Aug 01 '22 20:08 michalkurka

@michalkurka unfortunately not fix yet, it turns out that the problem was in TestFrameBuilder and assertion. I am continue with this issue.

valenad1 avatar Aug 01 '22 21:08 valenad1