h2o-3 icon indicating copy to clipboard operation
h2o-3 copied to clipboard

Pubdev-3451: add quiet argument to init

Open fennovj opened this issue 5 years ago • 6 comments

Hello h2o people,

Jira here: https://0xdata.atlassian.net/browse/PUBDEV-3451

This is my first contribution to h2o, so if I did anything wrong, just point it out. I hope I followed all the guidelines.

This is a new feature, that adds an option to the 'h2o.init' function, to surpress output. As mentioned in the Jira, this has advantages for R, because the outputs interfere with knitr documents, making it hard to use h2o in latex. Furthermore, the output can interfere with certain unit test or build pipelines. The progress bars can be disabled with "h2o.no_progress()". It would be nice if the startup connection messages could be disabled too.

The option is implemented slightly differently for R and Python. In Python, 'verbose' is set to False, meaning no connection messages are printed at all, including when shutting down, etcetera. In R, there is no such verbose mode, so only the messages during init are hidden, to match the Jira ticket.

fennovj avatar Nov 13 '18 08:11 fennovj

@fvermeij thank you for your contribution. It is very appreciated.

At a first glance, things look good!

@ledell was the requester of this change. Erin, can you please review?

michalkurka avatar Dec 20 '18 01:12 michalkurka

Mr. Jenkins, please test!

michalkurka avatar Dec 20 '18 01:12 michalkurka

Thanks, I will review this soon! Very nice idea, I think people have complained about this before.

ledell avatar Dec 21 '18 17:12 ledell

@fvermeij any chance you could resolve the merge conflicts? I would love to see this change implemented. When running h2o from cron, I don't want to see any output unless there is a problem.

swt2c avatar May 30 '19 20:05 swt2c

@fvermeij any chance you could resolve the merge conflicts? I would love to see this change implemented. When running h2o from cron, I don't want to see any output unless there is a problem.

Yes I fixed them :) I agree this would be a useful extra option for h2o, even though this PR has been inactive for a while.

fennovj avatar May 31 '19 07:05 fennovj

Hey, I'd love to see this implemented too. I commented this on the Jira ticket as well, but an important use case is Kaggle Notebooks. They are becoming popular ways to show others how to use an algorithm or software package. However, when using H2O for simple examples, much of the output consists of cluster diagnostics irrelevant to the algorithm itself and often poorly formatted. This gives the impression to novices that H2O is "heavy" or complicated when in reality it's user friendly due to things like automatic categorical feature encoding, lambda_search, and AutoML.

bscan avatar Nov 02 '19 17:11 bscan